Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756598Ab0G1Wg3 (ORCPT ); Wed, 28 Jul 2010 18:36:29 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:44958 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752206Ab0G1Wg0 (ORCPT ); Wed, 28 Jul 2010 18:36:26 -0400 Date: Wed, 28 Jul 2010 23:36:03 +0100 From: Russell King - ARM Linux To: Daniel Walker Cc: Jeff Ohlstein , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Steve Muckle , Catalin Marinas , Tony Lindgren , "Kirill A. Shutemov" Subject: Re: [PATCH 2/3] arm: mm: do not set missing flags on ScorpionMP Message-ID: <20100728223603.GB6729@n2100.arm.linux.org.uk> References: <1279911483-7039-1-git-send-email-johlstei@codeaurora.org> <1279911483-7039-3-git-send-email-johlstei@codeaurora.org> <20100724082334.GB15571@n2100.arm.linux.org.uk> <1280354280.21185.10.camel@c-dwalke-linux.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1280354280.21185.10.camel@c-dwalke-linux.qualcomm.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1503 Lines: 49 On Wed, Jul 28, 2010 at 02:58:00PM -0700, Daniel Walker wrote: > On Sat, 2010-07-24 at 09:23 +0100, Russell King - ARM Linux wrote: > > On Fri, Jul 23, 2010 at 11:58:02AM -0700, Jeff Ohlstein wrote: > > > From: Steve Muckle > > > > > > ScorpionMP does not have the SMP/nAMP mode and TLB ops > > > broadcasting bits in the ACTLR. > > > > Please provide a separate instance of __v7_proc_info for your processor > > and direct it to jump into the __v7_setup code after this setup instead. > > > You mean add another label into __v7_setup along with a proc-msm.S to > jump over this code? Yes to the first, no to the second. __v7_setup: #ifdef CONFIG_SMP mrc p15, 0, r0, c1, c0, 1 tst r0, #(1 << 6) @ SMP/nAMP mode enabled? orreq r0, r0, #(1 << 6) | (1 << 0) @ Enable SMP/nAMP mode and mcreq p15, 0, r0, c1, c0, 1 @ TLB ops broadcasting #endif __v7_msm_setup: ... .section ".proc.info.init", #alloc, #execinstr .type __v7_msm_proc_info, #object __v7_msm_proc_info: .long ... .long ... ... b __v7_msm_setup ... /* * Match any ARMv7 processor core. */ .type __v7_proc_info, #object __v7_proc_info: ... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/