Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755084Ab0G2JDk (ORCPT ); Thu, 29 Jul 2010 05:03:40 -0400 Received: from smtp.citrix.com ([66.165.176.89]:61501 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992Ab0G2JDj (ORCPT ); Thu, 29 Jul 2010 05:03:39 -0400 X-IronPort-AV: E=Sophos;i="4.55,279,1278302400"; d="scan'208";a="9561677" Subject: Re: [PATCH 1/4] irq: rename IRQF_TIMER to IRQF_NO_SUSPEND From: Ian Campbell To: Thomas Gleixner CC: "linux-kernel@vger.kernel.org" , "Jeremy Fitzhardinge" , Dmitry Torokhov , Benjamin Herrenschmidt , Paul Mackerras , Grant Likely , "xen-devel@lists.xensource.com" , "linux-input@vger.kernel.org" , "linuxppc-dev@ozlabs.org" , "devicetree-discuss@lists.ozlabs.org" In-Reply-To: References: <1280314445.24292.90.camel@zakaz.uk.xensource.com> <1280314467-5637-1-git-send-email-ian.campbell@citrix.com> Content-Type: text/plain; charset="UTF-8" Organization: Citrix Systems, Inc. Date: Thu, 29 Jul 2010 10:03:34 +0100 Message-ID: <1280394214.24292.1594.camel@zakaz.uk.xensource.com> MIME-Version: 1.0 X-Mailer: Evolution 2.30.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 26 On Thu, 2010-07-29 at 09:49 +0100, Thomas Gleixner wrote: > On Wed, 28 Jul 2010, Ian Campbell wrote: > > > Continue to provide IRQF_TIMER as an alias to IRQF_NO_SUSPEND since I > > think it is worth preserving the nice self-documenting name (where it > > is used appropriately). It also avoid needing to patch all the many > > users who are using the flag for an actual timer interrupt. > > I'm not happy about the alias. What about: > > #define __IRQF_TIMER 0x00000200 > #define IRQF_NO_SUSPEND 0x00000400 > > #define IRQF_TIMER (__IRQF_TIMER | IRQF_NO_SUSPEND) Sure, I'll rework along those lines. Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/