Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755801Ab0G2JSj (ORCPT ); Thu, 29 Jul 2010 05:18:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48568 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755629Ab0G2JSh (ORCPT ); Thu, 29 Jul 2010 05:18:37 -0400 Message-ID: <4C51473A.4000605@suse.cz> Date: Thu, 29 Jul 2010 11:17:46 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100520 SUSE/3.0.5 Thunderbird/3.0.5 MIME-Version: 1.0 To: Sam Ravnborg Cc: lkml , linux-kbuild , Stephen Rothwell , Roman Zippel , Uwe Kleine-Koig , Linus Torvalds Subject: Re: [RFC PATCH] kconfig: use long options in conf References: <20100725213808.GA5814@merkur.ravnborg.org> <20100725214021.GD5834@merkur.ravnborg.org> <4C4EFE80.7050808@suse.cz> <20100728203622.GA32086@merkur.ravnborg.org> In-Reply-To: <20100728203622.GA32086@merkur.ravnborg.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 22 On 28.7.2010 22:36, Sam Ravnborg wrote: > Hi Michal. > > I cooked up the following to introduce long options in conf. > But in the process I dropped the short options. Is this OK? Nice! I would probably name the option and the enum value for randconfig simply --randconfig to not introduce new names (the scripts/kconfig/conf call is displayed to the user). > Usign the same name in conf.c as used as make target really > helped the readability. Indeed. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/