Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757259Ab0G2LFA (ORCPT ); Thu, 29 Jul 2010 07:05:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:58755 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756932Ab0G2LBa (ORCPT ); Thu, 29 Jul 2010 07:01:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.55,279,1278313200"; d="scan'208";a="590877570" From: xiaohui.xin@intel.com To: netdev@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, mingo@elte.hu, davem@davemloft.net, herbert@gondor.hengli.com.au, jdike@linux.intel.com Cc: Xin Xiaohui Subject: [RFC PATCH v8 09/16] Don't do skb recycle, if device use external buffer. Date: Thu, 29 Jul 2010 19:14:41 +0800 Message-Id: <1280402088-5849-10-git-send-email-xiaohui.xin@intel.com> X-Mailer: git-send-email 1.5.4.4 In-Reply-To: <1280402088-5849-9-git-send-email-xiaohui.xin@intel.com> References: <1280402088-5849-1-git-send-email-xiaohui.xin@intel.com> <1280402088-5849-2-git-send-email-xiaohui.xin@intel.com> <1280402088-5849-3-git-send-email-xiaohui.xin@intel.com> <1280402088-5849-4-git-send-email-xiaohui.xin@intel.com> <1280402088-5849-5-git-send-email-xiaohui.xin@intel.com> <1280402088-5849-6-git-send-email-xiaohui.xin@intel.com> <1280402088-5849-7-git-send-email-xiaohui.xin@intel.com> <1280402088-5849-8-git-send-email-xiaohui.xin@intel.com> <1280402088-5849-9-git-send-email-xiaohui.xin@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 34 From: Xin Xiaohui Signed-off-by: Xin Xiaohui Signed-off-by: Zhao Yu Reviewed-by: Jeff Dike --- net/core/skbuff.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index bbf4707..9b156bb 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -565,6 +565,12 @@ int skb_recycle_check(struct sk_buff *skb, int skb_size) if (skb_shared(skb) || skb_cloned(skb)) return 0; + /* if the device wants to do mediate passthru, the skb may + * get external buffer, so don't recycle + */ + if (dev_is_mpassthru(skb->dev)) + return 0; + skb_release_head_state(skb); shinfo = skb_shinfo(skb); atomic_set(&shinfo->dataref, 1); -- 1.5.4.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/