Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756777Ab0G2Su6 (ORCPT ); Thu, 29 Jul 2010 14:50:58 -0400 Received: from mail-bw0-f46.google.com ([209.85.214.46]:56894 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755002Ab0G2Su4 (ORCPT ); Thu, 29 Jul 2010 14:50:56 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=w/xE48fzadRqY/1wTYDbAajkF2eH39JqJvTLRq8Y8hjdT34OVMb+ATZHBaexnL8arf YJnAE3MeTnWLYM9b9nLPx1SedGbSNxIW7lzduQMQdH3e1M9hZ7SYq7BmKqyIp0/4rcVK yK57cy8s3hvx1zIy3Z/2ubVMg///syJTaDop4= MIME-Version: 1.0 In-Reply-To: References: <4C505F86.7050509@cs.helsinki.fi> <4C519A6E.8000002@cs.helsinki.fi> Date: Thu, 29 Jul 2010 21:50:54 +0300 X-Google-Sender-Auth: ccyLoDZyupmDLh9U9eDDZMWpIEQ Message-ID: Subject: Re: [2.6.35-rc6 patch] increase kmemleak robustness at boot From: Pekka Enberg To: Daniel J Blueman Cc: Catalin Marinas , Linux Kernel Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 806 Lines: 18 On Thu, Jul 29, 2010 at 9:03 PM, Daniel J Blueman wrote: >> If it's just kmemleak_init() we're talking about, slab caches are up at that >> point so you can just use kmalloc(). > > The slab allocator isn't up at this point. With > CONFIG_DEBUG_KMEMLEAK_EARLY_LOG_SIZE set to 16K elements, an extra 3MB > of __initdata memory is used, but freed afterwards, and it works > great. Right. I guess the required earlylog buffer size would be smaller if we initialized kmemleak earlier. Can we do that in mm_init() after kmem_cache_init()? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/