Subject: Re: [PATCH v2] cpuidle: extend cpuidle and menu governor to handle
 dynamic states
From: Ai Li <aili@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dwalker@codeaurora.org, arjan@linux.intel.com, mingo@elte.hu,
        shemminger@vyatta.com, czoccolo@gmail.com, len.brown@intel.com,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-pm@lists.linux-foundation.org
In-Reply-To: <20100729124141.ee20b34b.akpm@linux-foundation.org>
References: <1280352443-28044-1-git-send-email-aili@codeaurora.org>
	 <20100728145545.35caf67a.akpm@linux-foundation.org>
	 <1280426600.22142.27.camel@ali-lnx.qualcomm.com>
	 <20100729114306.093cc58c.akpm@linux-foundation.org>
	 <1280430929.22142.51.camel@ali-lnx.qualcomm.com>
	 <20100729124141.ee20b34b.akpm@linux-foundation.org>
Content-Type: text/plain
Date: Thu, 29 Jul 2010 16:07:55 -0600
Message-Id: <1280441275.22142.75.camel@ali-lnx.qualcomm.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1798
Lines: 51

On Thu, 2010-07-29 at 12:41 -0700, Andrew Morton wrote:

> On Thu, 29 Jul 2010 13:15:29 -0600
> Ai Li <aili@codeaurora.org> wrote:
> 
> > On Thu, 2010-07-29 at 11:43 -0700, Andrew Morton wrote:
> > 
> > > I'd be reluctant to merge this code without also having code which uses
> > > it.  As it is the change is useless and untestable.
> > 
> > We have local code in the arch/arm/mach-msm branch that uses the new
> > cpuidle code.  We are still developing and testing the MSM patches, and
> > hope to upstream them in a few weeks.
> > 
> 
> grumble.
> 
> Well, please at least explain all this in the changelogs when you send
> out the next version.

Sure.  Or ...

On Thu, 2010-07-29 at 12:25 -0700, Daniel Walker wrote:
> On Thu, 2010-07-29 at 13:15 -0600, Ai Li wrote:
> > On Thu, 2010-07-29 at 11:43 -0700, Andrew Morton wrote:
> > 
> > > I'd be reluctant to merge this code without also having code which uses
> > > it.  As it is the change is useless and untestable.
> > 
> > We have local code in the arch/arm/mach-msm branch that uses the new
> > cpuidle code.  We are still developing and testing the MSM patches, and
> > hope to upstream them in a few weeks.
> 
> We can just re-submit this patch with our msm cpuidle code when that is
> finished.

If the consensus is that this is the better way, I can resubmit at the later
time.  I'll send out a new version of the patch this week so to incorporate
Andrew's comments.

~Ai

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/