Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751816Ab0G3Ecl (ORCPT ); Fri, 30 Jul 2010 00:32:41 -0400 Received: from smtp-out.google.com ([74.125.121.35]:9367 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013Ab0G3Ecj (ORCPT ); Fri, 30 Jul 2010 00:32:39 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:x-system-of-record; b=WEILRr8cvhPt1FcleoEhq5yXGbOwiThZUHw5pAczLwysmlILpUNv/ZvGQCD3xqsfL NqY31lthtvDVbmHIx3Whw== MIME-Version: 1.0 In-Reply-To: <20100730041825.GM14369@balbir.in.ibm.com> References: <201007282334.08063.rjw@sisk.pl> <20100729132325.59871484.kamezawa.hiroyu@jp.fujitsu.com> <20100729142245.4AA5.A69D9226@jp.fujitsu.com> <20100729142429.58b49dce.kamezawa.hiroyu@jp.fujitsu.com> <20100730041825.GM14369@balbir.in.ibm.com> Date: Thu, 29 Jul 2010 21:32:35 -0700 Message-ID: Subject: Re: Memory corruption during hibernation since 2.6.31 From: Hugh Dickins To: balbir@linux.vnet.ibm.com Cc: KAMEZAWA Hiroyuki , KOSAKI Motohiro , "Rafael J. Wysocki" , Ondrej Zary , Kernel development list , Andrew Morton , Andrea Arcangeli Content-Type: text/plain; charset=UTF-8 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 22 On Thu, Jul 29, 2010 at 9:18 PM, Balbir Singh wrote: > > Couldn't we reuse PF_* flags to differentiate between the paths, if > that is what it eventually boils down to? On an unrelated note, I was > looking at shrink_all_memory() and wondering if swappiness really > mattered there. So far as the swap-reuse issue goes, I don't see that a PF_ flag would help: the threads that already worry about such issues do the set_freezable()/try_to_freeze() thing, and won't get into trouble anyway; we don't want to force every other thread to have to do something special now, better just check global state in the very few places its needed. On the unrelated note: better in an unrelated thread! Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/