Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756027Ab0G3JJe (ORCPT ); Fri, 30 Jul 2010 05:09:34 -0400 Received: from helcar.apana.org.au ([209.40.204.226]:55281 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780Ab0G3JJc (ORCPT ); Fri, 30 Jul 2010 05:09:32 -0400 Date: Fri, 30 Jul 2010 17:09:22 +0800 From: Herbert Xu To: Changli Gao Cc: Jamal Hadi Salim , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] act_nat: the checksum of ICMP doesn't have pseudo header Message-ID: <20100730090922.GA7807@gondor.apana.org.au> References: <1280448258-1893-1-git-send-email-xiaosuo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1280448258-1893-1-git-send-email-xiaosuo@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 763 Lines: 19 On Fri, Jul 30, 2010 at 08:04:18AM +0800, Changli Gao wrote: > after updating the value of the ICMP payload, inet_proto_csum_replace4() should > be called with zero pseudohdr. > > Signed-off-by: Changli Gao No, the code is correct as is. We need to update the checksum even if the checksum is partial, which is what the 1 is for. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/