Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756318Ab0G3KYT (ORCPT ); Fri, 30 Jul 2010 06:24:19 -0400 Received: from helcar.apana.org.au ([209.40.204.226]:43846 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752726Ab0G3KYR (ORCPT ); Fri, 30 Jul 2010 06:24:17 -0400 Date: Fri, 30 Jul 2010 18:24:09 +0800 From: Herbert Xu To: Changli Gao Cc: Jamal Hadi Salim , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] act_nat: the checksum of ICMP doesn't have pseudo header Message-ID: <20100730102409.GA8590@gondor.apana.org.au> References: <1280448258-1893-1-git-send-email-xiaosuo@gmail.com> <20100730090922.GA7807@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 19 On Fri, Jul 30, 2010 at 06:10:19PM +0800, Changli Gao wrote: > > Is it really necessary, and I have noticed that netfilter doesn't call > inet_proto_csum_replace4 in this way. The checksum update is for the inner IP header. netfilter does of course update the checksum, it just doesn't do it here which is for the outer IP header. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/