Date: Fri, 30 Jul 2010 09:54:50 -0700
From: Greg KH <greg@kroah.com>
To: =?utf-8?Q?Micha=C5=82?= Nazarewicz <m.nazarewicz@samsung.com>
Cc: David Brownell <david-b@pacbell.net>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Dries Van Puymbroeck <Dries.VanPuymbroeck@dekimo.com>,
        Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCHv5 2/3] USB: gadget: Use new composite features in some
 gadgets
Message-ID: <20100730165450.GA4943@kroah.com>
References: <231296.268.qm@web180308.mail.gq1.yahoo.com>
 <op.vgn0zfyq7p4s8u@pikus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <op.vgn0zfyq7p4s8u@pikus>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 955
Lines: 26

On Fri, Jul 30, 2010 at 06:48:41PM +0200, Michał Nazarewicz wrote:
> >>-static unsigned short gfs_vendor_id    = 0x0525;    /* XXX NetChip */
> >>-static unsigned short gfs_product_id   = 0xa4ac;    /* XXX */
> 
> >Look -- you can't assign NetChip numbers!!!
> 
> /me ashamed
> 
> Obviously, you're absolutely right.  I left the XXX mark to remember
> to clear the situation with the IDs but then completely forgot about
> it after g_multi got pulled. (It's especially bad since there is a
> conflict with hid.c).
> 
> So, to fix the situation, I need to ask Greg for the IDs?

Yes you do.  We shouldn't be using _any_ netchip ids anymore now that we
have our own vendor id assigned to us.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/