Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758763Ab0G3RUu (ORCPT ); Fri, 30 Jul 2010 13:20:50 -0400 Received: from miranda.se.axis.com ([193.13.178.8]:55536 "EHLO miranda.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758901Ab0G3RUV (ORCPT ); Fri, 30 Jul 2010 13:20:21 -0400 Date: Fri, 30 Jul 2010 19:20:05 +0200 From: Jesper Nilsson To: Arnd Bergmann Cc: "linux-kernel@vger.kernel.org" , John Kacur , Frederic Weisbecker , linux-cris-kernel Subject: Re: [PATCH 07/12] cris: autoconvert trivial BKL users to private mutex Message-ID: <20100730172005.GE9784@axis.com> References: <1278883143-29035-1-git-send-email-arnd@arndb.de> <1278883143-29035-8-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278883143-29035-8-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 970 Lines: 26 On Sun, Jul 11, 2010 at 11:18:58PM +0200, Arnd Bergmann wrote: > All these files use the big kernel lock in a trivial > way to serialize their private file operations, > typically resulting from an earlier semi-automatic > pushdown from VFS. > > None of these drivers appears to want to lock against > other code, and they all use the BKL as the top-level > lock in their file operations, meaning that there > is no lock-order inversion problem. > > Consequently, we can remove the BKL completely, > replacing it with a per-file mutex in every case. > Using a scripted approach means we can avoid > typos. Thanks, added to the cris-tree. /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/