Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760196Ab0G3SQ2 (ORCPT ); Fri, 30 Jul 2010 14:16:28 -0400 Received: from smtp-out.google.com ([74.125.121.35]:1886 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760053Ab0G3SQU (ORCPT ); Fri, 30 Jul 2010 14:16:20 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:x-system-of-record; b=MivxUCCQHXjOGNfg3i7t3A1z+rbB6sTbqdX3p26evKhaC0AmzHCwmULn3QlKrmHwS V5cwJvbHE0UIXQ29yps5g== MIME-Version: 1.0 In-Reply-To: <20100730194359.e6761b78.kamezawa.hiroyu@jp.fujitsu.com> References: <201007282334.08063.rjw@sisk.pl> <20100729132325.59871484.kamezawa.hiroyu@jp.fujitsu.com> <20100729142245.4AA5.A69D9226@jp.fujitsu.com> <20100729142429.58b49dce.kamezawa.hiroyu@jp.fujitsu.com> <20100730090146.7e65d1c1.kamezawa.hiroyu@jp.fujitsu.com> <20100730131432.891df49a.kamezawa.hiroyu@jp.fujitsu.com> <20100730194359.e6761b78.kamezawa.hiroyu@jp.fujitsu.com> Date: Fri, 30 Jul 2010 11:16:16 -0700 Message-ID: Subject: Re: Memory corruption during hibernation since 2.6.31 From: Hugh Dickins To: KAMEZAWA Hiroyuki Cc: KOSAKI Motohiro , "Rafael J. Wysocki" , Ondrej Zary , Kernel development list , Andrew Morton , Balbir Singh , Andrea Arcangeli Content-Type: text/plain; charset=UTF-8 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 23 On Fri, Jul 30, 2010 at 3:43 AM, KAMEZAWA Hiroyuki wrote: > plz wait until the next week..I found I can't post today ;( > > Maybe trying my quick hack patch (posted) will be enough small for > backporting etc. Absolutely. I didn't intend my broader anxieties to distract from your immediate scan_swap_map() fix. If Ondrej finds that it does in fact fix the corruption he's been seeing since 2.6.31, then I'd like your fix to go straight to Linus for 2.6.35: once swap is 50% full, your case is rather too likely to occur; whereas I'm worrying about correctness in unlikely hypothetical circumstances. But please do credit Ondrej, and make clear that you're fixing an observed corrution; and feel free to add my Acked-by: Hugh Dickins Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/