Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285Ab0GaA71 (ORCPT ); Fri, 30 Jul 2010 20:59:27 -0400 Received: from terminus.zytor.com ([198.137.202.10]:52807 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102Ab0GaA70 (ORCPT ); Fri, 30 Jul 2010 20:59:26 -0400 Message-ID: <4C537514.9090109@zytor.com> Date: Fri, 30 Jul 2010 17:57:56 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1 MIME-Version: 1.0 To: Fenghua Yu CC: Ingo Molnar , Thomas Gleixner , Len Brown , Guenter Roeck , Chen Gong , Jean Delvare , Huaxu Wan , linux-kernel , lm-sensors Subject: Re: [PATCH V3 2/5] Package Level Thermal Control and Power Limit Notification: pkgtemp hwmon driver References: <1280448826-12004-1-git-send-email-fenghua.yu@intel.com> <1280448826-12004-3-git-send-email-fenghua.yu@intel.com> In-Reply-To: <1280448826-12004-3-git-send-email-fenghua.yu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 968 Lines: 23 On 07/29/2010 05:13 PM, Fenghua Yu wrote: > + > +enum { SHOW_TEMP, SHOW_TJMAX, SHOW_TTARGET, SHOW_LABEL, SHOW_NAME } SHOW; > + This conflicts with an equally poorly named global variable in drivers/hwmon/via-cputemp.c, and the conflict is causing a build failure. I think both these drivers have the same bug: a missing "typedef" before the enum keyword, as present in coretemp.c. Of course, one can question if it should be given a typename at all since in none of these drivers they are actually referenced by type, and instead the enumeration is just used as a source of constants, which can perfectly well be handled with an unnamed enum: enum { SHOW_TEMP, SHOW_TJMAX, SHOW_TTARGET, SHOW_LABEL, SHOW_NAME }; -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/