Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755850Ab0HADHv (ORCPT ); Sat, 31 Jul 2010 23:07:51 -0400 Received: from sh.osrg.net ([192.16.179.4]:33798 "EHLO sh.osrg.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754794Ab0HADHu (ORCPT ); Sat, 31 Jul 2010 23:07:50 -0400 Date: Sun, 1 Aug 2010 12:03:11 +0900 To: konrad@kernel.org Cc: fujita.tomonori@lab.ntt.co.jp, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, ak@linux.intel.com, konrad.wilk@oracle.com, akataria@vmware.com Subject: Re: [PATCH] swiotlb: enlarge iotlb buffer on demand From: FUJITA Tomonori In-Reply-To: <20100731010706.GA30319@andromeda.dapyr.net> References: <20100731003643E.fujita.tomonori@lab.ntt.co.jp> <20100730202724.GA920@andromeda.dapyr.net> <20100731010706.GA30319@andromeda.dapyr.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20100801120224F.fujita.tomonori@lab.ntt.co.jp> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (sh.osrg.net [192.16.179.4]); Sun, 01 Aug 2010 12:03:13 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1069 Lines: 23 On Fri, 30 Jul 2010 21:07:06 -0400 Konrad Rzeszutek Wilk wrote: > I took your patch and was trying to fit it over the > stable/swiotlb-0.8.4 branch and when I did so a found couple of things.. > > > > > @@ -215,14 +222,14 @@ swiotlb_late_init_with_default_size(size_t default_size) > > > bytes = io_tlb_nslabs << IO_TLB_SHIFT; > > You should also initialize the __io_tlb_start array first: Yeah, I know. As I wrote, this patchset breaks IA64. I really merge to swiotlb's two memory allocator mechanisms (swiotlb_init_with_default_size and swiotlb_late_init_with_default_size). I need to look at the x86 memory boot code after memblock surgery finishes. And as you know, I've not fixed the error path and swiotlb_free. I'll do later if people are not against swiotlb dynamic allocation. Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/