Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753987Ab0HALbX (ORCPT ); Sun, 1 Aug 2010 07:31:23 -0400 Received: from out6.bezeqint.net ([192.115.188.206]:52319 "EHLO out6.bezeqint.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752188Ab0HALbW (ORCPT ); Sun, 1 Aug 2010 07:31:22 -0400 X-Greylist: delayed 467 seconds by postgrey-1.27 at vger.kernel.org; Sun, 01 Aug 2010 07:31:21 EDT From: "Yehuda Mor" To: "'Sergei Shtylyov'" , "'Kulikov Vasiliy'" Cc: , "'David Brownell'" , "'Greg Kroah-Hartman'" , "'Tony Lindgren'" , "'Cory Maccarrone'" , , References: <1280597965-8525-1-git-send-email-segooon@gmail.com> <4C55472E.6000307@ru.mvista.com> In-Reply-To: <4C55472E.6000307@ru.mvista.com> Subject: Remove me!!!! Date: Sun, 1 Aug 2010 14:29:54 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AcsxYYYBtb6A9mdASHq2GEBvTfOiCgACq13Q Content-Language: he Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2208 Lines: 77 Please, remove my address praxis@actcom.co.il from your lists! I am receiving unwanted mail from a lot of people around kernel, ubuntu' debian, etc - and I have no idea why! Thank you. -----Original Message----- From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Sergei Shtylyov Sent: Sunday, August 01, 2010 1:07 PM To: Kulikov Vasiliy Cc: kernel-janitors@vger.kernel.org; David Brownell; Greg Kroah-Hartman; Tony Lindgren; Cory Maccarrone; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] usb: omap_udc: check return value of proc_create() Hello. Kulikov Vasiliy wrote: > proc_create() may fail, if so return -ENOMEM. > Signed-off-by: Kulikov Vasiliy [...] > diff --git a/drivers/usb/gadget/omap_udc.c b/drivers/usb/gadget/omap_udc.c > index f81e4f0..1083216 100644 > --- a/drivers/usb/gadget/omap_udc.c > +++ b/drivers/usb/gadget/omap_udc.c > @@ -2544,9 +2544,9 @@ static const struct file_operations proc_ops = { > .release = single_release, > }; > > -static void create_proc_file(void) > +static int create_proc_file(void) > { > - proc_create(proc_filename, 0, NULL, &proc_ops); > + return (proc_create(proc_filename, 0, NULL, &proc_ops) == NULL); Parens not needed around the *return* expression. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ __________ Information from ESET NOD32 Antivirus, version of virus signature database 5329 (20100731) __________ The message was checked by ESET NOD32 Antivirus. http://www.eset.com __________ Information from ESET NOD32 Antivirus, version of virus signature database 5329 (20100731) __________ The message was checked by ESET NOD32 Antivirus. http://www.eset.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/