Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752068Ab0HAXsI (ORCPT ); Sun, 1 Aug 2010 19:48:08 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:37224 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968Ab0HAXsG (ORCPT ); Sun, 1 Aug 2010 19:48:06 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=uhNCMojL9UiM/WW7rcgHkVjfZThlrZJxMXepvTpQ/w3Yzqk66e+OHRfHMVzLG9b/NZ 2hIE937GKaxYcWVL+bSbqp0G7+AOPGn7FdX1sqGrTcGJO/Mo2AArjKqCS1ICNXNEhxMs YpfSgqoRdBTD0oPZ/Ef4vlm4XrjcCQa/NO5hg= Message-ID: <4C5607AF.8020109@garzik.org> Date: Sun, 01 Aug 2010 19:47:59 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100720 Fedora/3.0.6-1.fc12 Thunderbird/3.0.6 MIME-Version: 1.0 To: Tejun Heo CC: mingo@elte.hu, tglx@linutronix.de, bphilips@suse.de, yinghai@kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, stern@rowland.harvard.edu, gregkh@suse.de, khali@linux-fr.org, Ashish Kalra , Saeed Bishara , Mark Lord , Robert Hancock Subject: Re: [PATCH 1/2 #upstream] sata_fsl,mv,nv: prepare for NCQ command completion update References: <1276443098-20653-1-git-send-email-tj@kernel.org> <1276443098-20653-12-git-send-email-tj@kernel.org> <4C23F6C1.7070603@garzik.org> <4C245E50.7090701@kernel.org> <4C247B54.2050900@garzik.org> <4C247C36.6040007@kernel.org> <4C24A903.4060908@kernel.org> In-Reply-To: <4C24A903.4060908@kernel.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 37 On 06/25/2010 09:02 AM, Tejun Heo wrote: > Make the following changes to prepare for NCQ command completion > update. Changes made by this patch don't cause any functional > difference. > > * sata_fsl_host_intr(): rename the local variable qc_active to > done_mask as that's what it is. > > * mv_process_crpb_response(): restructure if clause for easier update. > > * nv_adma_interrupt(): drop unnecessary error variable. > > * nv_swncq_sdbfis(): drop unnecessary nr_done and return 0 on success. > Typo fix. > > * nv_swncq_dmafis(): drop unused return value and return void. > > * nv_swncq_host_interrupt(): drop unnecessary return value handling. > > Signed-off-by: Tejun Heo > Cc: Ashish Kalra > Cc: Saeed Bishara > Cc: Mark Lord > Cc: Robert Hancock > --- > So, something like this. I tested both flavors of sata_nv but don't > have access to sata_mv or sata_fsl, but the conversion is pretty > straight forward and failures should be pretty easy to catch. applied -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/