Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752407Ab0HBDpR (ORCPT ); Sun, 1 Aug 2010 23:45:17 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:36927 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752050Ab0HBDpP (ORCPT ); Sun, 1 Aug 2010 23:45:15 -0400 X-AuditID: b753bd60-a82c0ba000005a63-eb-4c563f468a99 Message-ID: <4C563F44.9080300@hitachi.com> Date: Mon, 02 Aug 2010 12:45:08 +0900 From: Masami Hiramatsu Organization: Systems Development Lab., Hitachi, Ltd., Japan User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: Frederic Weisbecker Cc: Srikar Dronamraju , Peter Zijlstra , Ingo Molnar , Steven Rostedt , Randy Dunlap , Arnaldo Carvalho de Melo , Linus Torvalds , Christoph Hellwig , Oleg Nesterov , Mark Wielaard , Mathieu Desnoyers , Andrew Morton , Naren A Devaiah , Jim Keniston , "Frank Ch. Eigler" , Ananth N Mavinakayanahalli , LKML , "Paul E. McKenney" , 2nddept-manager@sdl.hitachi.co.jp Subject: Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_event interface References: <20100727110855.24690.26901.sendpatchset@localhost6.localdomain6> <20100727111045.24690.31897.sendpatchset@localhost6.localdomain6> <4C510BCE.4010704@hitachi.com> <20100802022055.GB5581@nowhere> In-Reply-To: <20100802022055.GB5581@nowhere> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAA== X-FMFTCR: RANGEA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2009 Lines: 64 Frederic Weisbecker wrote: > On Thu, Jul 29, 2010 at 02:04:14PM +0900, Masami Hiramatsu wrote: >> Srikar Dronamraju wrote: >>> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig >>> index c681fa7..16e2a8c 100644 >>> --- a/kernel/trace/Kconfig >>> +++ b/kernel/trace/Kconfig >>> @@ -482,6 +482,22 @@ config RING_BUFFER_BENCHMARK >>> >>> If unsure, say N. >>> >>> +config UPROBE_EVENT >>> + bool "Enable uprobes-based dynamic events" >>> + depends on ARCH_SUPPORTS_UPROBES >>> + depends on MMU >>> + select UPROBES >>> + select PROBE_EVENTS >>> + select TRACING >>> + default n >>> + help >>> + This allows the user to add tracing events on top of userspace dynamic >>> + events (similar to tracepoints) on the fly via the traceevents interface. >>> + Those events can be inserted wherever uprobes can probe, and record >>> + various registers. >>> + This option is required if you plan to use perf-probe subcommand of perf >>> + tools on user space applications. >>> + >> Possible enhancement: Moving this config right after KPROBE_EVENT, because >> those two provide similar dynamic events. >> >> Thank you, > > > In fact this could be a menu "Dynamic Probes", perhaps default off, inside > which Kprobes and Uprobes would be default on (but depend on "Dynamic Probes"). > > So that you can quickly enable them all in one. Hmm, I disagree with it, because both Kprobes and Uprobes provides APIs for modules too. I'd like to suggest below config tree Kenrel hacking - Kprobes - Uprobes - Tracing -- Dynamic Events depends on Kprobes || Uprobes or select Kprobes && Uprobes Thank you, -- Masami HIRAMATSU 2nd Research Dept. Hitachi, Ltd., Systems Development Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/