Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753265Ab0HBHqb (ORCPT ); Mon, 2 Aug 2010 03:46:31 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:55683 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753143Ab0HBHq3 (ORCPT ); Mon, 2 Aug 2010 03:46:29 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=a0NzQFzHhF1qjwD3askOIY/TREwtK98rP0yoRL7P1oRW0wgVwMU7RpxvanUpWLyqDi FS3hJoIRlRnqVEkoN1k8NYO6TKZfsZaMGWLX5gfAlT0jN2ZTutTWEXT7cSmTxnvvf7Pv joorQ2Gv9UdLdivLB0gpMZHkw9igsPQx8Bu7M= Date: Mon, 2 Aug 2010 09:46:23 +0200 From: Frederic Weisbecker To: Masami Hiramatsu Cc: Srikar Dronamraju , Peter Zijlstra , Ingo Molnar , Steven Rostedt , Randy Dunlap , Arnaldo Carvalho de Melo , Linus Torvalds , Christoph Hellwig , Oleg Nesterov , Mark Wielaard , Mathieu Desnoyers , Andrew Morton , Naren A Devaiah , Jim Keniston , "Frank Ch. Eigler" , Ananth N Mavinakayanahalli , LKML , "Paul E. McKenney" , 2nddept-manager@sdl.hitachi.co.jp Subject: Re: [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_event interface Message-ID: <20100802074619.GA5292@nowhere> References: <20100727110855.24690.26901.sendpatchset@localhost6.localdomain6> <20100727111045.24690.31897.sendpatchset@localhost6.localdomain6> <4C510BCE.4010704@hitachi.com> <20100802022055.GB5581@nowhere> <4C563F44.9080300@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C563F44.9080300@hitachi.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2263 Lines: 69 On Mon, Aug 02, 2010 at 12:45:08PM +0900, Masami Hiramatsu wrote: > Frederic Weisbecker wrote: > > On Thu, Jul 29, 2010 at 02:04:14PM +0900, Masami Hiramatsu wrote: > >> Srikar Dronamraju wrote: > >>> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig > >>> index c681fa7..16e2a8c 100644 > >>> --- a/kernel/trace/Kconfig > >>> +++ b/kernel/trace/Kconfig > >>> @@ -482,6 +482,22 @@ config RING_BUFFER_BENCHMARK > >>> > >>> If unsure, say N. > >>> > >>> +config UPROBE_EVENT > >>> + bool "Enable uprobes-based dynamic events" > >>> + depends on ARCH_SUPPORTS_UPROBES > >>> + depends on MMU > >>> + select UPROBES > >>> + select PROBE_EVENTS > >>> + select TRACING > >>> + default n > >>> + help > >>> + This allows the user to add tracing events on top of userspace dynamic > >>> + events (similar to tracepoints) on the fly via the traceevents interface. > >>> + Those events can be inserted wherever uprobes can probe, and record > >>> + various registers. > >>> + This option is required if you plan to use perf-probe subcommand of perf > >>> + tools on user space applications. > >>> + > >> Possible enhancement: Moving this config right after KPROBE_EVENT, because > >> those two provide similar dynamic events. > >> > >> Thank you, > > > > > > In fact this could be a menu "Dynamic Probes", perhaps default off, inside > > which Kprobes and Uprobes would be default on (but depend on "Dynamic Probes"). > > > > So that you can quickly enable them all in one. > > Hmm, I disagree with it, because both Kprobes and Uprobes provides > APIs for modules too. I'm not sure there is a point in maintaining a leightweight version for out of tree code. These modules could just select kprobes/uprobes events as well. As you prefer, that was just a suggestion to make it more simple. > > I'd like to suggest below config tree > > Kenrel hacking > - Kprobes > - Uprobes > - Tracing > -- Dynamic Events > depends on Kprobes || Uprobes Yep, that version looks good. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/