Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753437Ab0HBJqq (ORCPT ); Mon, 2 Aug 2010 05:46:46 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:53857 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753037Ab0HBJqp convert rfc822-to-8bit (ORCPT ); Mon, 2 Aug 2010 05:46:45 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8; format=flowed; delsp=yes Date: Mon, 02 Aug 2010 11:48:15 +0200 From: =?utf-8?B?TWljaGHFgiBOYXphcmV3aWN6?= Subject: Re: [PATCHv5 1/3] USB: gadget: composite: Better string override handling In-reply-to: <764692.87858.qm@web180303.mail.gq1.yahoo.com> To: Greg KH , David Brownell Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Dries Van Puymbroeck , Kyungmin Park Message-id: Organization: Samsung Electronics Content-transfer-encoding: 8BIT User-Agent: Opera Mail/10.60 (Linux) References: <764692.87858.qm@web180303.mail.gq1.yahoo.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 26 On Sun, 01 Aug 2010 21:05:33 +0200, David Brownell wrote: > NAK. You're still hard-wiring an un-managed serial number. Uh? I'm not. Current code overrides the serial number only when the iSerial module parameter is given: + if (iSerialNumber) + cdev->serial_override = + override_id(cdev, &cdev->desc.iSerialNumber); and when host requests string which ID is saved as a overridden for serial number the module parameter is taken. + else if (cdev->serial_override == id) + str = iSerialNumber; -- Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o | Computer Science, Michał "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/