Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752147Ab0HBNNx (ORCPT ); Mon, 2 Aug 2010 09:13:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11914 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532Ab0HBNNv (ORCPT ); Mon, 2 Aug 2010 09:13:51 -0400 Message-ID: <4C56C461.8020207@gmail.com> Date: Mon, 02 Aug 2010 15:13:05 +0200 From: Edward Shishkin User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Nick Piggin CC: Christian Stroetmann , Glenn D , linux-kernel , linux reiserfs-devel Subject: Re: Formal Reiser4 inclusion and todo list? References: <2E9381E6-A09A-4330-9A61-C4B7D7CE0E71@MailNewsRSS.com> <49F2CF9A.1060202@inn.nl> <49F2D43F.90105@ontolab.com> <8c113a260904250416n28fbdacs682ef8e6859b7dbf@mail.gmail.com> <49F339A2.9080705@ontolab.com> <200904252027.n3PKReMx073755@mail.meer.net> <49F393A1.4030004@gmail.com> <0d42c3ebde41a3d0bcc01f9fccc07f1c@mail.velocitynet.com.au> <4C508BFC.3010008@ontolinux.com> <4C5579E9.2030200@ontolinux.com> <20100802072540.GA7841@amd> In-Reply-To: <20100802072540.GA7841@amd> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2292 Lines: 75 Nick Piggin wrote: > On Sun, Aug 01, 2010 at 03:43:05PM +0200, Christian Stroetmann wrote: > >> Hi Glenn; >> >> On the 28.07.2010 21:58, I wrote: >> >>> Aloha Glenn; >>> >>> At the 28.07.2010 17:21, you (doiggl@velocitynet.com.au) wrote: >>> >>>>> The following items are still unaddressed: >>>>> >>>>> 1. running igrab() in the writepage() path is really going to hammer >>>>> inode_lock. Something else will need to be done here. >>>>> >>>>> 2. Running iput() in entd() is a bit surprising. iirc there >>>>> are various >>>>> ways >>>>> in which this can recur into the filesystem, perform I/O, etc. I >>>>> guess it >>>>> works.. >>>>> But again, it will hammer inode_lock. >>>>> > > inode_lock should be going away within 6 months or so, with the > vfs-scaling developments (see linux-fsdevel). > Yup, I keep a track of your efforts, it would be nice.. > Inode refcounting becomes very light-weight, as it should be. > > > >>>>> 3. the writeout logic in entd_flush() is interesting (as in >>>>> "holy cow"). >>>>> It's very central and really needs some good comments describing >>>>> >>>> what's >>>> >>>>> going on in there - what problems are being solved, which decisions >>>>> >>>> were >>>> >>>>> taken and why, etc. >>>>> >>>>> 4. reiser4_wait_page_writeback() needs commenting. >>>>> >>>>> 5. reading the comment in txnmgr.c regarding MAP_SHARED pages: a number >>>>> >>>> of >>>> >>>>> things have changed since then. We have page-becoming-writeable >>>>> notifications and probably soon we'll always take a >>>>> pagefault when a >>>>> MAP_SHARED page transitions from pte-clean to pte-dirty (although I >>>>> wouldn't >>>>> recommend that a filesystem rely upon the latter for a while yet). >>>>> > > It is now possible to trap all dirtying activity from all sources > except get_user_pages (but filesystems tend to ignore that little > problem). > Thanks for looking at this. Edward. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/