Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754418Ab0HBS2U (ORCPT ); Mon, 2 Aug 2010 14:28:20 -0400 Received: from terminus.zytor.com ([198.137.202.10]:52174 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754397Ab0HBS2R (ORCPT ); Mon, 2 Aug 2010 14:28:17 -0400 Message-ID: <4C570DFE.503@zytor.com> Date: Mon, 02 Aug 2010 11:27:10 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1 MIME-Version: 1.0 To: Thiago Farina CC: Yinghai Lu , Ingo Molnar , Thomas Gleixner , Cyrill Gorcunov , Pekka Enberg , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/2] x86, setup: reorgize the early_console_setup References: <4C56701B.1030000@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 739 Lines: 23 On 08/02/2010 10:56 AM, Thiago Farina wrote: > > These to functions above can be fairly simplified by writting as: > > static bool inline is_hex_digit(int c) { > return (c >= '0' && c <= '9') || > (c >= 'A' && c <= 'F') || > (c >= 'a' && c <= 'f'); > } > a) You lose the isdigit() functionality, which is useful on its own. b) Does this enahance readability in any way? c) Your proposed renaming is nonstandard. As such, I don't think this is a good idea. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/