Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754644Ab0HBTAV (ORCPT ); Mon, 2 Aug 2010 15:00:21 -0400 Received: from andromeda.dapyr.net ([206.212.254.10]:49799 "EHLO andromeda.dapyr.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143Ab0HBTAT (ORCPT ); Mon, 2 Aug 2010 15:00:19 -0400 Date: Mon, 2 Aug 2010 14:59:25 -0400 From: Konrad Rzeszutek Wilk To: Mike Christie Cc: James Bottomley , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Jayamohan Kallickal , Randy Dunlap , linux-scsi Subject: Re: linux-next: build failure after merge of the final tree (scsi-post-merge tree related) Message-ID: <20100802185925.GA32503@andromeda.dapyr.net> References: <20100803024445.0bf7ec86.sfr@canb.auug.org.au> <20100803024701.b3dff69a.sfr@canb.auug.org.au> <1280768048.2843.242.camel@mulgrave.site> <4C570464.9010204@cs.wisc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C570464.9010204@cs.wisc.edu> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2199 Lines: 55 On Mon, Aug 02, 2010 at 12:46:12PM -0500, Mike Christie wrote: > On 08/02/2010 11:54 AM, James Bottomley wrote: > >missing linux-scsi added to cc list. > > > >On Tue, 2010-08-03 at 02:47 +1000, Stephen Rothwell wrote: > >>Hi all, > >> > >>On Tue, 3 Aug 2010 02:44:45 +1000 Stephen Rothwell > >>wrote: > >>> > >>>After merging the final tree, today's linux-next build (powerpc > >>>allmodconfig) > >>>failed like this: > >>> > >>>ERROR: ".iscsi_boot_destroy_kset" [drivers/scsi/be2iscsi/be2iscsi.ko] > >>>undefined! > >>>ERROR: ".iscsi_boot_create_host_kset" > >>>[drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > >>>ERROR: ".iscsi_boot_create_target" [drivers/scsi/be2iscsi/be2iscsi.ko] > >>>undefined! > >>>ERROR: ".iscsi_boot_create_initiator" > >>>[drivers/scsi/be2iscsi/be2iscsi.ko] undefined! > >>>ERROR: ".iscsi_boot_create_ethernet" [drivers/scsi/be2iscsi/be2iscsi.ko] > >>>undefined! > >>> > >>>Caused by commit a33e2a708b2e83ee6111e45c8d3d49a112c3c887 ("[SCSI] > >>>be2iscsi: Add support for iscsi boot"). For some reason, commit > >>>ed94aa526655d915076dcdbbf4fc962b2a67fcb5 ("[SCSI] be2iscsi: select > >>>ISCSI_BOOT_SYSFS") was not sufficient to make sure that > >>>CONFIG_ISCSI_BOOT_SYSFS is defined for this build. > >> > >>It turns out that drivers/firmware/Kconfig is only included on x86, ia64 > >>and blackfin. > > > >OK, we need to turn this around then and make be2iscsi only use iscsi > >boot if it's enabled ... that's going to be some fun #ifdefing in the > >driver. > > > > I think my mistake was to put iscsi_boot_sysfs in drivers/firmware. The Yikes. Last minute change, eh? > interface is generic and should be used on any arch and with anything > (ibft or iscsi driver) that wants to export iscsi boot info. The > attached patch moves iscsi_boot_sysfs to drivers/scsi. It was made over > linux-next. I have only compile tested it. did you compile test it with the x86 native iBFT driver? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/