Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754272Ab0HBWrT (ORCPT ); Mon, 2 Aug 2010 18:47:19 -0400 Received: from terminus.zytor.com ([198.137.202.10]:52585 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753144Ab0HBWrS (ORCPT ); Mon, 2 Aug 2010 18:47:18 -0400 Message-ID: <4C574AB6.5030403@zytor.com> Date: Mon, 02 Aug 2010 15:46:14 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1 MIME-Version: 1.0 To: Yinghai Lu CC: Cyrill Gorcunov , Ingo Molnar , Thomas Gleixner , Pekka Enberg , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH -v3 2/2] x86: more early console output from compressed/misc.c References: <4C56701B.1030000@kernel.org> <4C5670DA.2080703@zytor.com> <4C5680D2.4020302@kernel.org> <4C568D2B.205@kernel.org> <4C568D6F.3050004@kernel.org> <20100802174916.GD5544@lenovo> <4C5710C1.8020809@zytor.com> <20100802185410.GE5544@lenovo> <4C57153F.7030107@zytor.com> <4C571DF2.5080100@kernel.org> <4C5731AF.9040009@zytor.com> <4C5733CF.20100@zytor.com> <4C57382E.8050501@zytor.com> <4C574700.1080000@kernel.org> In-Reply-To: <4C574700.1080000@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 27 First, I'm not quite sure which 1/2 patch you're expecting this to be compiled against. On 08/02/2010 03:30 PM, Yinghai Lu wrote: > > + if (debug) { > + putstr("decompress_kernel:\n"); > + printf(" input: [0x%lx-0x%lx], output: 0x%lx, heap: [0x%lx-0x%lx]\n", > + (unsigned long)input_data, > + (unsigned long)input_data + input_len - 1, > + (unsigned long)output, > + (unsigned long)heap, > + (unsigned long)heap + BOOT_HEAP_SIZE - 1); > + } > + This seems to be the only user of printf() in the code. As such, I really suspect it's not worth pulling in all of printf(). I'd be willing to be convinced, but if so I need (a) a concrete usage case, and (b) it should be a separate patch. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/