Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756474Ab0HCPec (ORCPT ); Tue, 3 Aug 2010 11:34:32 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:46610 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754125Ab0HCPeb (ORCPT ); Tue, 3 Aug 2010 11:34:31 -0400 Date: Tue, 3 Aug 2010 11:34:26 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Valdis.Kletnieks@vt.edu cc: "Justin P. Mattock" , , , , Subject: Re: [PATCH 1/2]drivers/usb/core/sysfs.c Fix variable 'retval' set but not used In-Reply-To: <66093.1280848412@localhost> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 19 On Tue, 3 Aug 2010 Valdis.Kletnieks@vt.edu wrote: > > Failure to create a file in sysfs is almost never fatal and usually not > > even dangerous. Ignoring the error is generally better than failing > > the entire operation. > > Then why the __must_check attribute if it's usually ignorable? I thought > that was reserved for functions that you damned sight better well check > for errors because bad things are afoot otherwise? That's a good question. Perhaps Greg KH knows the answer. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/