Date: Tue, 3 Aug 2010 08:46:15 -0700
From: Greg KH <gregkh@suse.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Valdis.Kletnieks@vt.edu, "Justin P. Mattock" <justinmattock@gmail.com>,
        linux-usb@vger.kernel.org, dbrownell@users.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2]drivers/usb/core/sysfs.c Fix variable 'retval' set
 but not used
Message-ID: <20100803154615.GA32034@suse.de>
References: <66093.1280848412@localhost>
 <Pine.LNX.4.44L0.1008031133270.1853-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.44L0.1008031133270.1853-100000@iolanthe.rowland.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1006
Lines: 25

On Tue, Aug 03, 2010 at 11:34:26AM -0400, Alan Stern wrote:
> On Tue, 3 Aug 2010 Valdis.Kletnieks@vt.edu wrote:
> 
> > > Failure to create a file in sysfs is almost never fatal and usually not 
> > > even dangerous.  Ignoring the error is generally better than failing 
> > > the entire operation.
> > 
> > Then why the __must_check attribute if it's usually ignorable? I thought
> > that was reserved for functions that you damned sight better well check
> > for errors because bad things are afoot otherwise?
> 
> That's a good question.  Perhaps Greg KH knows the answer.

You should check the return value for that function.  To not do that is
a bug.  This one looks like it snuck through.  Fixing it properly is the
correct thing to do.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/