Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932279Ab0HCQM3 (ORCPT ); Tue, 3 Aug 2010 12:12:29 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:57245 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756265Ab0HCQM2 (ORCPT ); Tue, 3 Aug 2010 12:12:28 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=cEDxFkvwmNDvBD6UsBszbaCmtN7cXqeKS5+vJwcxwosk9km99yCzhabSBahbXngMhs Au/3s35pXdjbmpDEbRPgYZ/BfUYiRQsGtEnzaUuaEQiElgX8tGi3P93b+BJJFlTztrLt 8L/KVuanR8LgFDXkgoyDyxJg6HlbFNpWON3KU= Message-ID: <4C583FFA.4080506@gmail.com> Date: Tue, 03 Aug 2010 09:12:42 -0700 From: "Justin P. Mattock" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100615 Lightning/1.0b2pre Thunderbird/3.0.4 MIME-Version: 1.0 To: Alan Stern CC: Valdis.Kletnieks@vt.edu, linux-usb@vger.kernel.org, dbrownell@users.sourceforge.net, gregkh@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2]drivers/usb/core/sysfs.c Fix variable 'retval' set but not used References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1436 Lines: 41 On 08/03/2010 08:36 AM, Alan Stern wrote: > On Tue, 3 Aug 2010, Justin P. Mattock wrote: > >> On 08/03/2010 07:29 AM, Alan Stern wrote: >>> On Tue, 3 Aug 2010 Valdis.Kletnieks@vt.edu wrote: >>> >>>> On Mon, 02 Aug 2010 21:26:28 PDT, "Justin P. Mattock" said: >>>>> diff --git a/drivers/usb/core/sysfs.c b/drivers/usb/core/sysfs.c >>>> >>>>> if (alt->string) >>>>> - retval = device_create_file(&intf->dev,&dev_attr_interface); >>>>> + device_create_file(&intf->dev,&dev_attr_interface); >>>>> intf->sysfs_files_created = 1; >>>>> return 0; >>> >>> Justin, did you try compiling your new code? Those unused values are >>> there because device_create_file is declared as __must_check. >>> >> >> I went as far as compiling, once I saw no warning then figured o.k >> I'll send out what I have for feedback then go from there. >> (and just for the record I want to thank those who took the time to go >> through and give feedback). > > It's a little surprising that you didn't get any warning. I guess you > don't have CONFIG_ENABLE_MUST_CHECK turned on. > > Alan Stern > > no nothing.. just the original warning.. as for MUST_CHECK yeah your right it's off. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/