Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932461Ab0HCSzJ (ORCPT ); Tue, 3 Aug 2010 14:55:09 -0400 Received: from moutng.kundenserver.de ([212.227.17.8]:56378 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756565Ab0HCSzH (ORCPT ); Tue, 3 Aug 2010 14:55:07 -0400 From: Stefan Weil To: netdev@vger.kernel.org Cc: Stefan Weil , "David S. Miller" , Chaithrika U S , Sriramakrishnan , Kevin Hilman , linux-kernel@vger.kernel.org Subject: [PATCH] davinci_emac: Fix use after free in davinci_emac_remove Date: Tue, 3 Aug 2010 20:53:45 +0200 Message-Id: <1280861625-4804-1-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.7.1 X-Provags-ID: V02:K0:eorQbfwqy57GgmvmYxIRg3MIPGXfEf4DaFvBm2kA0O4 466c6kOoJu9G05rExrxyN61L5sALwqSonHRfZr3u8/wtNO5kxw 4YBKCKGHKipvjgvavmxAn5Gu2r5tVC+l7Yywk6MBdHVQkELqdw /glmfIUeDTYLFdx9pS/NpgdH0KS35LvyGUm0wqV3FYd/yyQnec vwXZSj28TnqCRYznes+aVjVA/MVw6gPcAt2beb+FYOevyXPq3I eIcey+XyH8xWo Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1255 Lines: 38 free_netdev finally calls kfree which makes the contents of ndev and priv (private data contained in ndev) invalid. So iounmap should be called before free_netdev. Cc: David S. Miller Cc: Chaithrika U S Cc: Sriramakrishnan Cc: Kevin Hilman Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Stefan Weil --- drivers/net/davinci_emac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c index 8cc8a43..866e6b8 100644 --- a/drivers/net/davinci_emac.c +++ b/drivers/net/davinci_emac.c @@ -2818,8 +2818,8 @@ static int __devexit davinci_emac_remove(struct platform_device *pdev) release_mem_region(res->start, res->end - res->start + 1); unregister_netdev(ndev); - free_netdev(ndev); iounmap(priv->remap_addr); + free_netdev(ndev); clk_disable(emac_clk); clk_put(emac_clk); -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/