Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757292Ab0HCVk5 (ORCPT ); Tue, 3 Aug 2010 17:40:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37114 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753993Ab0HCVkz (ORCPT ); Tue, 3 Aug 2010 17:40:55 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <19826.1280811821@neuling.org> References: <19826.1280811821@neuling.org> <19789.1280811783@neuling.org> To: Michael Neuling Cc: dhowells@redhat.com, stable@kernel.org, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Layton Subject: Re: [PATCH 2.6.32/stable] CIFS: Remove __exit mark from cifs_init_dns_resolver() header Date: Tue, 03 Aug 2010 22:40:25 +0100 Message-ID: <12482.1280871625@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 24 Michael Neuling wrote: > An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this error > > fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'cifs_init_dns_resolver' > > This removes the __init from cifs_init_dns_resolver() That's not really a good idea as the assembler may choose different pieces of assembly to do variable references and jumps, depending on the section information. A better fix is to add: #include to the header file. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/