Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757814Ab0HCVyu (ORCPT ); Tue, 3 Aug 2010 17:54:50 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:60998 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756424Ab0HCVyt (ORCPT ); Tue, 3 Aug 2010 17:54:49 -0400 MIME-Version: 1.0 In-Reply-To: <1280871336-31046-2-git-send-email-wad@chromium.org> References: <1280871336-31046-2-git-send-email-wad@chromium.org> From: Kay Sievers Date: Tue, 3 Aug 2010 23:54:33 +0200 Message-ID: Subject: Re: [PATCH 2/2] genhd, efi: add efi partition metadata to hd_structs To: Will Drewry Cc: linux-kernel@vger.kernel.org, Jens Axboe , Karel Zak , Tejun Heo , "David S. Miller" , Andrew Morton , Joe Perches Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 25 On Tue, Aug 3, 2010 at 23:35, Will Drewry wrote: > This change extends the partition_meta_info structure to > support EFI GPT-specific metadata and ensures that data > is copied in on partition scanning. > > Adding this information would make it possible to identify a > partition by GUID using something like disk_part_iter_*(), > calls that make hd_struct accessible, or even class_find_device. Wow, you are fast. :) Sounds and looks good to me. I guess we should assign the meta structure only after all values are filled in? Otherwise we could get partial reads from a possible user? Did you already test to put a lookup-call to the in-kernel mounter, if we use some special partition table uuid identifier for root=? That would be nice to see, if all that works as expected, and we can get to the data we collect. Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/