DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=6vAGGK0vwjFSI5sMNrzPgZv6qvGHagFXN+D9ofbcDZ32GFTvtEHTU9KpC4JxbCO38O2wtoJrPx74iFCDBrq6AsM2GSz+0Qz1pV5nOHtjtxvBeH3C7xFVjKXSTXqsm1qexX80yTEG9679XdPrZDibiblSlJ1dxT7p5ETK6RtA8XM=;
Message-ID: <811063.41186.qm@web37605.mail.mud.yahoo.com>
Date: Wed, 4 Aug 2010 00:50:20 -0700 (PDT)
From: Alex Dubov <oakad@yahoo.com>
Subject: Re: [PATCH 1/2] MEMSTICK: fix hangs on unexpected device removal in mspro_blk
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <1280847186-11501-2-git-send-email-maximlevitsky@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1552
Lines: 57

--- On Tue, 3/8/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:

> Now that del_gendisk syncs, we better
> start rejecting requests right away.


I don't quite see why this change is needed. My understanding is, user
accessible interface should be marked as removed as early, as possible.


> 
> Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
> ---
>  drivers/memstick/core/mspro_block.c |? ? 5
> +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/memstick/core/mspro_block.c
> b/drivers/memstick/core/mspro_block.c
> index 8327e24..8d27c13 100644
> --- a/drivers/memstick/core/mspro_block.c
> +++ b/drivers/memstick/core/mspro_block.c
> @@ -1330,13 +1330,14 @@ static void
> mspro_block_remove(struct memstick_dev *card)
>  ??? struct mspro_block_data *msb =
> memstick_get_drvdata(card);
>  ??? unsigned long flags;
>  
> -??? del_gendisk(msb->disk);
> -??? dev_dbg(&card->dev, "mspro block
> remove\n");
>  ??? spin_lock_irqsave(&msb->q_lock,
> flags);
>  ??? msb->eject = 1;
>  ??? blk_start_queue(msb->queue);
>  ???
> spin_unlock_irqrestore(&msb->q_lock, flags);
>  
> +??? del_gendisk(msb->disk);
> +??? dev_dbg(&card->dev, "mspro block
> remove\n");
> +
>  ??? blk_cleanup_queue(msb->queue);
>  ??? msb->queue = NULL;
>  
> -- 
> 1.7.0.4
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/