Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756441Ab0HDH7H (ORCPT ); Wed, 4 Aug 2010 03:59:07 -0400 Received: from hera.kernel.org ([140.211.167.34]:46458 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756077Ab0HDH7C (ORCPT ); Wed, 4 Aug 2010 03:59:02 -0400 Message-ID: <4C591DCC.7080104@kernel.org> Date: Wed, 04 Aug 2010 09:59:08 +0200 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1 MIME-Version: 1.0 To: Will Drewry CC: linux-kernel@vger.kernel.org, Kay Sievers , Jens Axboe , Karel Zak , "David S. Miller" , Andrew Morton , Joe Perches , Jan Blunck , Greg Kroah-Hartman Subject: Re: [PATCH v2 2/3] genhd, efi: add efi partition metadata to hd_structs References: <1280887483-2979-2-git-send-email-wad@chromium.org> In-Reply-To: <1280887483-2979-2-git-send-email-wad@chromium.org> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (hera.kernel.org [127.0.0.1]); Wed, 04 Aug 2010 07:58:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 27 Hello, On 08/04/2010 04:04 AM, Will Drewry wrote: > struct partition_meta_info { > enum partition_meta_info_format_t format; > union { > +#ifdef CONFIG_EFI_PARTITION > + struct { > + efi_guid_t uuid; > + efi_guid_t type; > + efi_char16_t label[72 / sizeof(efi_char16_t)]; > + } efi; > +#endif It would be nice if uuid can be made a common field outside of the union so that generic code which only cares about UUID can simply read it off. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/