Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757535Ab0HDLA2 (ORCPT ); Wed, 4 Aug 2010 07:00:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36283 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755789Ab0HDLA0 (ORCPT ); Wed, 4 Aug 2010 07:00:26 -0400 Date: Wed, 4 Aug 2010 13:00:23 +0200 From: Matthias Hopf To: Zhang Rui Cc: Len Brown , Matthew Garrett , Andrew Morton , Julia Lawall , Oliver Neukum , "linux-acpi@vger.kernel.org" , "linux-pm@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ACPI / PM: Traverse video_device_list for backlight restoration Message-ID: <20100804110023.GA17385@suse.de> Mail-Followup-To: Zhang Rui , Len Brown , Matthew Garrett , Andrew Morton , Julia Lawall , Oliver Neukum , "linux-acpi@vger.kernel.org" , "linux-pm@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" References: <20100803100505.GA26948@suse.de> <20100803101157.GA29721@suse.de> <1280885249.1779.97.camel@rui> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1280885249.1779.97.camel@rui> Organization: SUSE LINUX Products GmbH, =?iso-8859-1?Q?G?= =?iso-8859-1?Q?F=3A_Markus_Rex=2C_HRB_16746_=28AG_N=FCrnberg=29?= User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1911 Lines: 52 On Aug 04, 10 09:27:29 +0800, Zhang Rui wrote: > On Tue, 2010-08-03 at 18:11 +0800, Matthias Hopf wrote: > > The .bind_info is later used in acpi_video_resume() to re-set the backlight > > - but it's only evaluated on the active_list[], on which all .bind_info are > > NULL by construction. > why? .bind_info in active_list is initialized in acpi_video_device_bind. Hm. Right. acpi_video_bus_get_one_device() is called after _enumerate(). Dunno why I didn't read this correctly. > > I don't understand > > why the list is (partially) transformed into an array in the first place, > > especially as both the array *and* the list are used in the code... > > > no, the active_list is an array in fact, which equals > acpi_video_bus->attached_array. Maybe we need to change it to a more > proper name. :-) > I'm still wondering why the patch works for you. Same to me. > could you please attach the acpidump output of this laptop? Will do. > please rebuild your kernel with CONFIG_ACPI_DEBUG=y, and reboot with > kernel parameter "acpi.debug_layer=0x10 acpi.debug_level=0x400". > and attach the dmesg output after resume, both w/ and w/o the patch you > attached. The most intriguing thing here is that the system starts writing to /var/log/messages continuously, thus dmesg output is sort-of worthless. This might be a reasonable side effect, it might be an indication of the original issue. I'll try to compile something for you. Thanks Matthias -- Matthias Hopf __ __ __ Maxfeldstr. 5 / 90409 Nuernberg (_ | | (_ |__ mat@mshopf.de Phone +49-911-74053-715 __) |_| __) |__ R & D www.mshopf.de -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/