Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753611Ab0HDP3I (ORCPT ); Wed, 4 Aug 2010 11:29:08 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:62749 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600Ab0HDP3G convert rfc822-to-8bit (ORCPT ); Wed, 4 Aug 2010 11:29:06 -0400 MIME-Version: 1.0 In-Reply-To: References: <1280887483-2979-2-git-send-email-wad@chromium.org> <20100804090049.GH5464@nb.net.home> From: Kay Sievers Date: Wed, 4 Aug 2010 17:28:47 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] genhd, efi: add efi partition metadata to hd_structs To: Will Drewry Cc: Tejun Heo , Karel Zak , linux-kernel@vger.kernel.org, Jens Axboe , "David S. Miller" , Andrew Morton , Joe Perches , Jan Blunck , Greg Kroah-Hartman Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1203 Lines: 25 On Wed, Aug 4, 2010 at 16:44, Will Drewry wrote: > On Wed, Aug 4, 2010 at 5:14 AM, Kay Sievers wrote: >> But the only thing we are really interested in is the UUID, which, >> like Tejun already suggested, we should probably store >> format-independent, and have it always accessible. That way, we would >> not need any type-specific parser, we just handle the normal DCE >> format. > > I'll bump it out and make it the efi code generic-ify its uuid.  Out > of curiousity, were you and Tejun thinking of keeping it as a 36 byte > string or as the 16 byte packed value.  While less space efficient, > I'd prefer the u8[36] as it avoids dealing with versioning when > parsing the user-supplied string.  Instead, each partition type can > properly unparse its uuids according to what they expect. I think we should use the packed version, which is case-insensitive, or at least normalize it to a defined case. Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/