Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758198Ab0HDRJq (ORCPT ); Wed, 4 Aug 2010 13:09:46 -0400 Received: from cantor.suse.de ([195.135.220.2]:60815 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757773Ab0HDRJo (ORCPT ); Wed, 4 Aug 2010 13:09:44 -0400 Date: Wed, 4 Aug 2010 10:05:24 -0700 From: Greg KH To: Hank Janssen Cc: "'linux-kernel@vger.kernel.org'" , "'devel@driverdev.osuosl.org'" , "'virtualization@lists.osdl.org'" , Haiyang Zhang Subject: Re: [PATCH 3/6] staging: hv: Fixed the value of the 64bit-hole inside ring buffer Message-ID: <20100804170524.GC28217@suse.de> References: <8AFC7968D54FB448A30D8F38F259C56223FD1D45@TK5EX14MBXC114.redmond.corp.microsoft.com> <20100803174405.GF1455@suse.de> <8AFC7968D54FB448A30D8F38F259C56223FE7ADB@TK5EX14MBXC114.redmond.corp.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8AFC7968D54FB448A30D8F38F259C56223FE7ADB@TK5EX14MBXC114.redmond.corp.microsoft.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 30 On Wed, Aug 04, 2010 at 04:25:40AM +0000, Hank Janssen wrote: > > >>On Tue, Aug 03, 2010 at 05:31:57PM +0000, Hank Janssen wrote: > >> From: Haiyang Zhang > >> > >> Fixed the value of the 64bit-hole inside ring buffer, this caused a problem on Hyper-V > >>when running checked Windows builds. > > > >What was the problem, and why would this fix it? Was it a bug in this code, > >by virtue that the code was incorrect in the client and the checked builds properly warned > >of this, or something else? > > Checked builds of Windows are used internally and given to external system builders at times. > They are builds that for example that all elements in a structure follow the definition of that > Structure. The bug this fixed was for a field that we did not fill in at all (Because we do > Not use it on the Linux side), and the checked build of windows gives errors on it internally > to the Windows logs. > > This fixes that error. Wonderful, please provide this information in the changelog comment. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/