Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754158Ab0HEE0c (ORCPT ); Thu, 5 Aug 2010 00:26:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2466 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719Ab0HEE02 (ORCPT ); Thu, 5 Aug 2010 00:26:28 -0400 Date: Thu, 5 Aug 2010 00:26:12 -0400 From: Valerie Aurora To: Miklos Szeredi Cc: viro@zeniv.linux.org.uk, jblunck@suse.de, hch@infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 21/38] union-mount: Support for mounting union mount file systems Message-ID: <20100805042612.GA19533@shell> References: <1276627208-17242-1-git-send-email-vaurora@redhat.com> <1276627208-17242-22-git-send-email-vaurora@redhat.com> <20100804195008.GB2134@shell> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100804195008.GB2134@shell> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 35 On Wed, Aug 04, 2010 at 03:50:08PM -0400, Valerie Aurora wrote: > On Wed, Aug 04, 2010 at 04:55:39PM +0200, Miklos Szeredi wrote: > > On Tue, 15 Jun 2010, Valerie Aurora wrote: > > > Create and tear down union mount structures on mount. Check > > > requirements for union mounts. This version clones the read-only > > > mounts and puts them in an array hanging off the superblock of the > > > topmost layer. > > > > If I do > > > > mount -r fs1 /mnt > > mount -r fs2 /mnt > > mount -ounion fs3 /mnt > > > > then only fs2 and fs3 will be unioned. > > > > Or how are multiple read-only layers supposed to work? > > You have it right, this is a bug in lookup in the last version I sent > out. I had commented out the part of my test suite that actually > tested three layer mounts so I didn't notice when I broke it. :/ I'll > post a new version with the fix today. Try branch "for_miklos" in: git://git.kernel.org/pub/scm/linux/kernel/git/val/linux-2.6.git It's against 2.6.34, I'm rebasing against 2.6.35 tomorrow. -VAL -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/