Date: Wed, 4 Aug 2010 23:10:51 -0600
From: dann frazier <dannf@hp.com>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: linux-kernel@vger.kernel.org, Thomas Mingarelli <thomas.mingarelli@hp.com>
Subject: Re: [PATCH 09/15] Despecificate driver from iLO2
Message-ID: <20100805051051.GD11497@ldl.fc.hp.com>
References: <1280274663-9160-1-git-send-email-dannf@hp.com>
 <1280274663-9160-10-git-send-email-dannf@hp.com>
 <20100804201341.GC30740@infomag.iguana.be>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100804201341.GC30740@infomag.iguana.be>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1824
Lines: 52

On Wed, Aug 04, 2010 at 10:13:41PM +0200, Wim Van Sebroeck wrote:
> Hi Dan,
> 
> > This driver supports both iLO2 and iLO3, but our user-visible strings
> > currently only reference iLO2. Let's just call it "iLO" to avoid having
> > to update strings for each iLO generation. This driver doesn't support
> > iLO ASICs prior to iLO2, but that is sufficiently explained in Kconfig.
> 
> Just a thought: Wouldn't it be more consistent if it's called iLO2+
> everywhere?

works for me :)

> 
> > -	tristate "HP Proliant iLO 2 Hardware Watchdog Timer"
> > +	tristate "HP Proliant iLO Hardware Watchdog Timer"
> 
> would be: tristate "HP Proliant iLO2+ Hardware Watchdog Timer"
> 
> > -	.identity = "HP iLO2 HW Watchdog Timer",
> > +	.identity = "HP iLO HW Watchdog Timer",
> 
> and: .identity = "HP iLO2+ HW Watchdog Timer",
> 
> > -	 * First let's find out if we are on an iLO2 server. We will
> > +	 * First let's find out if we are on an iLO2+ server. We will
> 
> > -		dev_warn(&dev->dev,
> > -			"This server does not have an iLO2 ASIC.\n");
> > +		dev_warn(&dev->dev, "This server does not have an iLO ASIC"
> > +			 " version 2 or greater.\n");
> 
> dev_warn(&dev->dev,
> 	"This server does not have an iLO2+ ASIC.\n");
> 
> > -			"Unable to detect the iLO2 server memory.\n");
> > +			"Unable to detect the iLO server memory.\n");
> 
> "Unable to detect the iLO2+ server memory.\n");
> 
> For the rest I'm still reviewing the code.

Thanks - I'll make this change in my local git tree for now and
resubmit after you've completed the review.

-- 
dann frazier | ProLiant Linux
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/