Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758940Ab0HEK5d (ORCPT ); Thu, 5 Aug 2010 06:57:33 -0400 Received: from hera.kernel.org ([140.211.167.34]:50277 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758889Ab0HEK53 (ORCPT ); Thu, 5 Aug 2010 06:57:29 -0400 Message-ID: <4C5A98A0.4030208@kernel.org> Date: Thu, 05 Aug 2010 12:55:28 +0200 From: Tejun Heo User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1 MIME-Version: 1.0 To: Will Drewry CC: linux-kernel@vger.kernel.org, Kay Sievers , Jens Axboe , Karel Zak , "David S. Miller" , Andrew Morton , Joe Perches , Jan Blunck , Greg Kroah-Hartman Subject: Re: [PATCH v3 3/3] init: add support for root devices specified by partition UUID References: <1280946126-19587-3-git-send-email-wad@chromium.org> In-Reply-To: <1280946126-19587-3-git-send-email-wad@chromium.org> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (hera.kernel.org [127.0.0.1]); Thu, 05 Aug 2010 10:57:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 38 Hello, On 08/04/2010 08:22 PM, Will Drewry wrote: > @@ -642,6 +642,7 @@ void __init printk_all_partitions(void) > struct hd_struct *part; > char name_buf[BDEVNAME_SIZE]; > char devt_buf[BDEVT_SIZE]; > + u8 uuid[PARTITION_META_INFO_UUIDLTH * 2 + 1]; > > /* > * Don't show empty devices or things that have been > @@ -660,10 +661,14 @@ void __init printk_all_partitions(void) > while ((part = disk_part_iter_next(&piter))) { > bool is_part0 = part == &disk->part0; > > - printk("%s%s %10llu %s", is_part0 ? "" : " ", > + uuid[0] = 0; > + if (part->info) > + part_unpack_uuid(part->info->uuid, uuid); > + > + printk("%s%s %10llu %s %s", is_part0 ? "" : " ", > bdevt_str(part_devt(part), devt_buf), > (unsigned long long)part->nr_sects >> 1, > - disk_name(disk, part->partno, name_buf)); > + disk_name(disk, part->partno, name_buf), uuid); Hmmm... I'm a bit worried about this. This might break userspace tools. I think it would be better to export it via sysfs. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/