Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758957Ab0HELH4 (ORCPT ); Thu, 5 Aug 2010 07:07:56 -0400 Received: from mail.pod.cz ([213.155.227.146]:58411 "EHLO mail.pod.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758849Ab0HELHx (ORCPT ); Thu, 5 Aug 2010 07:07:53 -0400 Date: Thu, 5 Aug 2010 13:07:50 +0200 From: Vitezslav Samel To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, "Nikita V. Youshchenko" , linuxpps@ml.enneenne.com, Rodolfo Giometti , john stultz , Andrew Morton , Tejun Heo , Joonwoo Park Subject: Re: [PATCHv3 03/16] pps: fix race in PPS_FETCH handler Message-ID: <20100805110750.GA10965@pc11.op.pod.cz> Mail-Followup-To: Alexander Gordeev , linux-kernel@vger.kernel.org, "Nikita V. Youshchenko" , linuxpps@ml.enneenne.com, Rodolfo Giometti , john stultz , Andrew Morton , Tejun Heo , Joonwoo Park References: <033148d225d9e4929fcc02ed8de0fcfa3637cffe.1280952801.git.lasaine@lvk.cs.msu.su> <20100805051929.GA14413@pc11.op.pod.cz> <20100805141951.2cce9490@desktopvm.lvknet> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20100805141951.2cce9490@desktopvm.lvknet> User-Agent: Mutt/1.5.20 (2009-08-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2720 Lines: 61 On Thu, Aug 05, 2010 at 02:19:51PM +0400, Alexander Gordeev wrote: > Hi Vitezslav, > > В Thu, 5 Aug 2010 07:19:29 +0200 > Vitezslav Samel пишет: > > > On Thu, Aug 05, 2010 at 01:06:40AM +0400, Alexander Gordeev wrote: > > > There was a race in PPS_FETCH ioctl handler when several processes want > > > to obtain PPS data simultaneously using sleeping PPS_FETCH. They all > > > sleep most of the time in the system call. > > > With the old approach when the first process waiting on the pps queue > > > is waken up it makes new system call right away and zeroes pps->go. So > > > other processes continue to sleep. This is a clear race condition > > > because of the global 'go' variable. > > > With the new approach pps->last_ev holds some value increasing at each > > > PPS event. PPS_FETCH ioctl handler saves current value to the local > > > variable at the very beginning so it can safely check that there is a > > > new event by just comparing both variables. > > > > > > Signed-off-by: Alexander Gordeev > > > --- > > > drivers/pps/kapi.c | 4 ++-- > > > drivers/pps/pps.c | 10 +++++++--- > > > include/linux/pps_kernel.h | 2 +- > > > 3 files changed, 10 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c > > > index 55f3961..3f89f5e 100644 > > > --- a/drivers/pps/kapi.c > > > +++ b/drivers/pps/kapi.c > > > @@ -326,8 +326,8 @@ void pps_event(int source, struct pps_ktime *ts, int event, void *data) > > > > > > /* Wake up if captured something */ > > > if (captured) { > > > - pps->go = ~0; > > > - wake_up_interruptible(&pps->queue); > > > + pps->last_ev++; > > > + wake_up_interruptible_all(&pps->queue); > > > > What happens if pps->last_ev overflows? Seems to me it would freeze > > pps. > > Yes, it will freeze the fds (if they don't use timeouts). But in normal > circumstances, i.e. when pps_event is called twice a second, it will > overflow after ~68 years of uninterrupted work. Well, it's the same > kind of problem as an overflow of struct timespec. I thought it's not > actually a problem. Should I use u64 instead of unsigned int or add a > runtime check somewhere? If we're using 1PPS it's ~68 years, but someone is trying 5PPS now (it would overflow in ~13.6 years) - what if someone tries e.g. 100PPS? It's not the same as overflow of struct timespec! I think it deserves some treatment. Cheers, Vita -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/