Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934055Ab0HEUvS convert rfc822-to-quoted-printable (ORCPT ); Thu, 5 Aug 2010 16:51:18 -0400 Received: from mail-gy0-f174.google.com ([209.85.160.174]:53511 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932155Ab0HEUvN convert rfc822-to-8bit (ORCPT ); Thu, 5 Aug 2010 16:51:13 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=yCY4gm+xfGDU7yg1VXHV/supnVpvLIonMDK+zrNQtcfygISmKDxZVFwjhn0nSrXlf1 Gzuj62NlDYGUSp8o6Zq1ta10dYk0sgkzl73pQM02CXNDgschc0YiLY2SJMFxOnpIMgWm uPoLMLzGNmKCxb73/SbwrOxgP8Msv6vSrzd9g= MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 5 Aug 2010 22:51:12 +0200 Message-ID: Subject: Re: [PATCH 42/42] drivers/media/video/bt8xx: Adjust confusing if indentation From: Luca Tettamanti To: Julia Lawall Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from QUOTED-PRINTABLE to 8bit by mail.home.local id o75KqdOV021014 Content-Length: 979 Lines: 27 Hi, one minor comment: On Thu, Aug 5, 2010 at 10:29 PM, Julia Lawall wrote: > From: Julia Lawall > > Indent the branch of an if. [...] > diff --git a/drivers/media/video/bt8xx/bttv-i2c.c b/drivers/media/video/bt8xx/bttv-i2c.c > index 685d659..695765c 100644 > --- a/drivers/media/video/bt8xx/bttv-i2c.c > +++ b/drivers/media/video/bt8xx/bttv-i2c.c > @@ -123,7 +123,7 @@ bttv_i2c_wait_done(struct bttv *btv) >        if (wait_event_interruptible_timeout(btv->i2c_queue, >                btv->i2c_done, msecs_to_jiffies(85)) == -ERESTARTSYS) > > -       rc = -EIO; > +               rc = -EIO; I'd also remove the empty line before the indented statement, it's confusing... Luca -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/