Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934249Ab0HEVlO (ORCPT ); Thu, 5 Aug 2010 17:41:14 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:49549 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756668Ab0HEVlF (ORCPT ); Thu, 5 Aug 2010 17:41:05 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=uiI2HeVBS6lNK7B144kjOH1LB24Bb/2woleLvU0riAuqruTSrfH8PGRfBL4RiCUnyi /Dl6eHwEb2ma8asq0MXNyAOERK39VGqSbH7WXGk4Gx8BF7K7lg/L0t3sif4p3QtBuK0K osvuUrFGSGVfoVQ5eU6NbhpnQyCvBV9VTGHx4= MIME-Version: 1.0 In-Reply-To: References: <921858.63779.qm@web180313.mail.gq1.yahoo.com> Date: Thu, 5 Aug 2010 23:41:03 +0200 X-Google-Sender-Auth: 08fYlCuqQ9gmEPvP9CTDdqKibbw Message-ID: Subject: Re: [spi-devel-general] [PATCH 26/42] drivers/spi/amba-pl022.c: Adjust confusing if indentation From: Linus Walleij To: Julia Lawall Cc: David Brownell , spi-devel-general@lists.sourceforge.net, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 587 Lines: 17 2010/8/5 Julia Lawall : > From: Julia Lawall > > The return -EINVAL appears to only make sense if the if branch that it is > aligned with is taken, so move it into that branch What a nasty bug to see, thanks for robot-finding this! Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/