Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933131Ab0HEXtO (ORCPT ); Thu, 5 Aug 2010 19:49:14 -0400 Received: from mail-wy0-f174.google.com ([74.125.82.174]:38429 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755711Ab0HEXtK (ORCPT ); Thu, 5 Aug 2010 19:49:10 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=xFCPBTzR3d7F9v1jA2/BMuhFb5jXEWfqM5P/ZwN0cQPBlqRJDnVxfiUXNoSacXXKdK YNYCTNTqZYsLIATuOcGcePIsQZWTclBCTjOIlQi8WIbzxgcglVCB/sc8Xg7Aoo/Gv8sN s4yrqhKIFo2PdeNaFa9PeaIZc8Vd+dync2cSk= Date: Fri, 6 Aug 2010 01:48:32 +0200 From: Dan Carpenter To: Julia Lawall Cc: Faisal Latif , Chien Tung , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 4/42 v2] drivers/infiniband/hw/nes: Adjust confusing if indentation Message-ID: <20100805234831.GK9031@bicker> Mail-Followup-To: Dan Carpenter , Julia Lawall , Faisal Latif , Chien Tung , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 32 I think the white space is meant to look like this. I did look at whether the "sq_cqes = 0;" should only be done if netif_queue_stopped(). In the end I decided this was what was intended, but it would be better if someone more familiar with the code reviewed it. Reported-by: Julia Lawall Signed-off-by: Dan Carpenter --- v2: changed different indents diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c index 57874a1..293977b 100644 --- a/drivers/infiniband/hw/nes/nes_hw.c +++ b/drivers/infiniband/hw/nes/nes_hw.c @@ -2737,9 +2737,9 @@ void nes_nic_ce_handler(struct nes_device *nesdev, struct nes_hw_nic_cq *cq) nesnic->sq_tail &= nesnic->sq_size-1; if (sq_cqes > 128) { barrier(); - /* restart the queue if it had been stopped */ - if (netif_queue_stopped(nesvnic->netdev)) - netif_wake_queue(nesvnic->netdev); + /* restart the queue if it had been stopped */ + if (netif_queue_stopped(nesvnic->netdev)) + netif_wake_queue(nesvnic->netdev); sq_cqes = 0; } } else { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/