Message-ID: <4C5B5077.1060901@linux.intel.com>
Date: Thu, 05 Aug 2010 16:59:51 -0700
From: Arjan van de Ven <arjan@linux.intel.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5
MIME-Version: 1.0
To: Kevin Hilman <khilman@deeprootsystems.com>
CC: "Rafael J. Wysocki" <rjw@sisk.pl>, Arjan van de Ven <arjan@infradead.org>,
        "linux-pm@lists.linux-foundation.org" 
	<linux-pm@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Ming Lei <tom.leiming@gmail.com>
Subject: Re: [PATCH v2] pm: Add runtime PM statistics
References: <20100710095254.5ab7291c@infradead.org>	<201007112326.07541.rjw@sisk.pl>	<20100711221646.35f11b70@infradead.org>	<201007132328.28853.rjw@sisk.pl> <4C3F2CEF.2090404@linux.intel.com> <87bp9gpryb.fsf@deeprootsystems.com>
In-Reply-To: <87bp9gpryb.fsf@deeprootsystems.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2212
Lines: 62

On 8/5/2010 4:20 PM, Kevin Hilman wrote:
> Arjan van de Ven<arjan@linux.intel.com>  writes:
>
>    
>> +
>> +/**
>> + * update_pm_runtime_accounting - Update the time accounting of power
>> states
>> + * @dev: Device to update the accounting for
>> + *
>> + * In order to be able to have time accounting of the various power states
>> + * (as used by programs such as PowerTOP to show the effectiveness of
>> runtime
>> + * PM), we need to track the time spent in each state.
>> + * update_pm_runtime_accounting must be called each time before the
>> + * runtime_status field is updated, to account the time in the old state
>> + * correctly.
>> + */
>> +void update_pm_runtime_accounting(struct device *dev)
>> +{
>> +    unsigned long now = jiffies;
>> +    int delta;
>> +
>> +    delta = now - dev->power.accounting_timestamp;
>> +
>> +    if (delta<  0)
>> +        delta = 0;
>> +
>> +    dev->power.accounting_timestamp = now;
>> +
>> +    if (dev->power.disable_depth>  0)
>> +        return;
>> +
>> +    if (dev->power.runtime_status == RPM_SUSPENDED)
>> +        dev->power.suspended_jiffies += delta;
>> +    else
>> +        dev->power.active_jiffies += delta;
>> +}
>>      
> By using jiffies, I think we might miss events in drivers that are doing
> runtime PM transitions in short bursts.  On embedded systems with slow
> HZ, there could potentially be lots of transitions between ticks.
>
> It would be nicer to use clocksource-based time so transitions between
> jiffies could still be factored into the accounting.
>    

you're absolutely right that the current mechanism is more "sampling 
accuracy" (similar to most /proc info that shows up with top and such).

on the "slow HZ".. there is no more valid reason to not set HZ to 
1000... so we'll get 1 msec sampling rate basically.

the problem with a more accurate clocksource is that it's expensive. And 
more... the path to such clocksource itself might be subject to power 
management ;-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/