Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932771Ab0HFAHw (ORCPT ); Thu, 5 Aug 2010 20:07:52 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:52148 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755696Ab0HFAHt (ORCPT ); Thu, 5 Aug 2010 20:07:49 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=aoWc6hiJcqrc6byagsmUzmMcHLtX+pbdtYIoMxs6B2B0vy4tmyCMVqiJsjsODS3qXu pdT/o6y5cPQoJLftLNxnqaPuc7bd6QubZM8D50W3FONk8CD73rj1ZmcrnSk+I22uoNoZ 789z9mAeNKYxvnGwOzeDtDVLArkUwZ6v0fB8A= Subject: [PATCH 1/2 RESEND] regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write() From: Axel Lin To: linux-kernel Cc: Liam Girdwood , Mark Brown , Marek Szyprowski , Kyungmin Park Content-Type: text/plain Date: Fri, 06 Aug 2010 08:09:14 +0800 Message-Id: <1281053354.12131.4.camel@mola> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1026 Lines: 34 We already check count value before calling i2c_smbus_read_byte_data(), no need to check it again. Signed-off-by: Axel Lin Acked-by: Mark Brown --- This resend adds regulator: prefix in the subject line. drivers/regulator/lp3971.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c index d4d9822..3bb82b6 100644 --- a/drivers/regulator/lp3971.c +++ b/drivers/regulator/lp3971.c @@ -377,7 +377,7 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count, if (count != 1) return -EIO; ret = i2c_smbus_read_byte_data(i2c, reg); - if (ret < 0 || count != 1) + if (ret < 0) return -EIO; *dest = ret; -- 1.5.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/