Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760703Ab0HFCBz (ORCPT ); Thu, 5 Aug 2010 22:01:55 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:52160 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759160Ab0HFCBu convert rfc822-to-8bit (ORCPT ); Thu, 5 Aug 2010 22:01:50 -0400 MIME-Version: 1.0 In-Reply-To: <20100806014057.GA22395@gondor.apana.org.au> References: <23662.1281056463@redhat.com> <20100806011706.GA21657@gondor.apana.org.au> <20100806014057.GA22395@gondor.apana.org.au> From: Linus Torvalds Date: Thu, 5 Aug 2010 19:01:21 -0700 Message-ID: Subject: Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem To: Herbert Xu Cc: David Howells , gregkh@suse.de, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 24 On Thu, Aug 5, 2010 at 6:40 PM, Herbert Xu wrote: > > -config CRYPTO_MANAGER_TESTS > - ? ? ? bool "Run algolithms' self-tests" > - ? ? ? default y > - ? ? ? depends on CRYPTO_MANAGER2 > +config CRYPTO_MANAGER_DISABLE_TESTS > + ? ? ? bool "Disable run-time self tests" > + ? ? ? depends on CRYPTO_MANAGER2 && EMBEDDED Why do you still want to force-enable those tests? I was going to complain about the "default y" anyway, now I'm _really_ complaining, because you've now made it impossible to disable those tests. Why? People always think that their magical code is so important. I tell you up-front that is absolutely is not. Just remove the crap entirely, please. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/