Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761020Ab0HFCXw (ORCPT ); Thu, 5 Aug 2010 22:23:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38253 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760380Ab0HFCXr (ORCPT ); Thu, 5 Aug 2010 22:23:47 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <23662.1281056463@redhat.com> <20100806011706.GA21657@gondor.apana.org.au> <20100806014057.GA22395@gondor.apana.org.au> To: Linus Torvalds Cc: dhowells@redhat.com, Herbert Xu , gregkh@suse.de, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: Initcall ordering problem (TTY vs modprobe vs MD5) and cryptomgr problem Date: Fri, 06 Aug 2010 03:23:30 +0100 Message-ID: <11274.1281061410@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 18 Linus Torvalds wrote: > People always think that their magical code is so important. I tell > you up-front that is absolutely is not. Just remove the crap entirely, > please. Even if he does remove it, that still leaves the problem that modprobe can be invoked and fail before tty_init() gets called:-/ I wonder if tty_init() should be moved up, perhaps to immediately after chrdev_init(). David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/