Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934780Ab0HFOwY (ORCPT ); Fri, 6 Aug 2010 10:52:24 -0400 Received: from caiajhbdcagg.dreamhost.com ([208.97.132.66]:60200 "EHLO homiemail-a4.g.dreamhost.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759702Ab0HFOwV (ORCPT ); Fri, 6 Aug 2010 10:52:21 -0400 Subject: Re: [PATCH RESEND] Fix /proc/softirqs file formatting From: Davidlohr Bueso Reply-To: dave@gnu.org To: Keika Kobayashi Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Linus Torvalds In-Reply-To: <4C56089B.9090405@ncos.nec.co.jp> References: <1280516809.1955.0.camel@cowboy> <4C56089B.9090405@ncos.nec.co.jp> Content-Type: text/plain; charset="UTF-8" Date: Fri, 06 Aug 2010 10:52:16 -0400 Message-ID: <1281106336.1945.0.camel@cowboy> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2223 Lines: 82 On Mon, 2010-08-02 at 08:51 +0900, Keika Kobayashi wrote: > (2010/07/31 4:06), Davidlohr Bueso wrote: > > Hi, > > > > The length of the BLOCK_IPOLL string is making it's value be printed too > > far to the right. This patch fixes this and makes the output a bit > > neater. > > > > Currently: > > CPU0 > > HI: 0 > > TIMER: 599792 > > NET_TX: 2 > > NET_RX: 6 > > BLOCK: 80807 > > BLOCK_IOPOLL: 0 > > TASKLET: 20012 > > SCHED: 0 > > HRTIMER: 63 > > RCU: 619279 > > > > With patch: > > CPU0 > > HI: 0 > > TIMER: 585582 > > NET_TX: 2 > > NET_RX: 6 > > BLOCK: 80320 > > BLOCK_IOPOLL: 0 > > TASKLET: 19287 > > SCHED: 0 > > HRTIMER: 62 > > RCU: 604441 > > > > > > > > Thanks, > > Davidlohr > > > > > > Signed-off-by: Davidlohr Bueso > > --- > > fs/proc/softirqs.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/fs/proc/softirqs.c b/fs/proc/softirqs.c > > index 1807c24..3799473 100644 > > --- a/fs/proc/softirqs.c > > +++ b/fs/proc/softirqs.c > > @@ -10,13 +10,13 @@ static int show_softirqs(struct seq_file *p, void *v) > > { > > int i, j; > > > > - seq_printf(p, " "); > > + seq_printf(p, " "); > > for_each_possible_cpu(i) > > seq_printf(p, "CPU%-8d", i); > > seq_printf(p, "\n"); > > > > for (i = 0; i < NR_SOFTIRQS; i++) { > > - seq_printf(p, "%8s:", softirq_to_name[i]); > > + seq_printf(p, "%12s:", softirq_to_name[i]); > > for_each_possible_cpu(j) > > seq_printf(p, " %10u", kstat_softirqs_cpu(i, j)); > > seq_printf(p, "\n"); > > Sorry for late response. > > It looks good to me. > > // Keika Kobayashi Then, if no one objects, can we get it added upstream? Thanks, Davidlohr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/