Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965788Ab0HFWzG (ORCPT ); Fri, 6 Aug 2010 18:55:06 -0400 Received: from mail-qw0-f46.google.com ([209.85.216.46]:58535 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965201Ab0HFWzB convert rfc822-to-8bit (ORCPT ); Fri, 6 Aug 2010 18:55:01 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Telt7jBXmd5QChDNc7+SKgZgo5YN0s7htTjSe+kMCuQ7SYhexMsdzxDfjzCrXf5TQP UD0YJ0S0E2hPZtbVTJAxREEYzL6eaP5Nd7R8xjoPNfwQSUdIfo3GAq1cpOv4nbl9fE41 5IXJMPR6YJIZULpmbfBT98H55BLvHWojrKz3U= MIME-Version: 1.0 In-Reply-To: References: <1277811391-17966-1-git-send-email-linus.walleij@stericsson.com> <20100805071235.GA436@morgana.i.gnudd.com> Date: Sat, 7 Aug 2010 00:54:59 +0200 Message-ID: Subject: Re: [PATCH 2/2] DMAENGINE: driver for the ARM PL080/PL081 PrimeCells From: Linus Walleij To: Dan Williams Cc: Alessandro Rubini , peter.pearse@arm.com, viresh.kumar@st.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, yuanyabin1978@sina.com, ben-linux@fluff.org, kgene.kim@samsung.com, rmk@arm.linux.org.uk Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 19 2010/8/6 Dan Williams : >?One > thing that should be on the todo list is to review the usage of memory > barriers. ?I don't think they are serving the purpose that you think > they are. All of those are from Peters original implementation, I never use any barriers so they actually looked alien to me. Unless I get a clear rationale from Peter I'll just remove them all for the time being in the fix-up version due after updating to generic slave control. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/