Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965096Ab0HFXbW (ORCPT ); Fri, 6 Aug 2010 19:31:22 -0400 Received: from cantor.suse.de ([195.135.220.2]:44092 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755157Ab0HFXbR convert rfc822-to-8bit (ORCPT ); Fri, 6 Aug 2010 19:31:17 -0400 Date: Sat, 7 Aug 2010 09:30:57 +1000 From: Neil Brown To: Steve French Cc: Jeremy Allison , Jeff Layton , utz lehmann , Linus Torvalds , Volker.Lendecke@sernet.de, David Howells , Jan Engelhardt , linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-fsde@jasper.es Subject: Re: [PATCH 02/18] xstat: Add a pair of system calls to make extended file stats available [ver #6] Message-ID: <20100807093057.7683bedd@notabene> In-Reply-To: References: <20100715021709.5544.64506.stgit@warthog.procyon.org.uk> <20100715021712.5544.44845.stgit@warthog.procyon.org.uk> <30448.1279800887@redhat.com> <1280524978.2452.9.camel@segv.aura.of.mankind> <20100801092529.5e6ba0e0@corrin.poochiereds.net> <20100805235218.GB31233@jeremy-laptop> <20100806133836.49757af9@notabene> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3481 Lines: 73 On Thu, 5 Aug 2010 22:55:06 -0500 Steve French wrote: > On Thu, Aug 5, 2010 at 10:38 PM, Neil Brown wrote: > > On Thu, 5 Aug 2010 16:52:18 -0700 > > Jeremy Allison wrote: > > >> Don't add it as an EA. It's *not* an EA, it's a timestamp. > > > > I'm curious.  Why do you particularly care what interface the kernel uses to > > provide you with access to this attribute? > > > > And given that it is an attribute that is not part of 'POSIX' or "UNIX", it > > would seem to be an extension - an extended attribute. > > As the Linux kernel does virtually nothing with this attribute except provide > > access, it seems to be a very different class of thing to other timestamps. > > Surely it is simply some storage associated with a file which is capable of > > storing a timestamp, which can be set or retrieved by an application, and > > which happens to be initialised to the current time when a file is created. > > > > Yes, to you it is a timestamp.  But to Linux it is a few bytes of > > user-settable metadata.  Sounds like an EA to me. > > > > Or do you really want something like BSD's 'btime' which as I understand it > > cannot be set.  Would that be really useful to you? > > Obviously the cifs and SMB2 protocols which Samba server support can > ask the server to set the create time of a file (this is handled > through xattrs today along with the "dos attribute" flags such as > archive/hidden/system), but certainly it is much more common (and > important) to read the creation time of an existing file. > Just a point of clarification - when you say it is common and important to be able to read the creation time on an existing file, and you still talking in the context of cifs/smb windows compatibility, or are you talking in the broader context? If you are referring to a broader context could be please give more details because I have not heard any mention of any real value of creation-time out side of window interoperability - have such a use clearly documented would assist the conversation I think. If on the other hand you are just referring the the windows interoperability context ... given that you have to read an EA if the create-time has been changed, you will always have to read and EA so having something else is pointless ... or I'm missing something. > > > Is there something important that I am missing? > > It is another syscall that Samba server would have to make - and xattr > performance is extremely slow on some file systems (although > presumably this one would be more likely to be stored in inode and > perhaps not as bad on ext4, cifs and a few others such as ntfs). > > Obviously if we were to make xattrs the preferred way to get create time out of the filesystem we would want to make sure it is efficient. It would seem to make perfect sense to add a 'getxattrat' syscall and allow an AT_NONBLOCK flag (which would probably be useful for statat too). The AT_NONBLOCK flag would only get attributes if they were available immediately without going to storage/network/whatever. And if it is simply a case of too many syscalls per file, then getxattrat_multi would seem to be the most general way to go. NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/