Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1762571Ab0HGJ7T (ORCPT <rfc822;w@1wt.eu>);
	Sat, 7 Aug 2010 05:59:19 -0400
Received: from mail-ww0-f42.google.com ([74.125.82.42]:44184 "EHLO
	mail-ww0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1762345Ab0HGJ7R (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 7 Aug 2010 05:59:17 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:mail-followup-to:references
         :mime-version:content-type:content-disposition:in-reply-to
         :user-agent;
        b=C2Im06TI8ylSE51JEMwfFas3UUM1Rwr47G61Hdn+xOEGZHX1vHCWJW+W9VyCFphh+k
         3OF+kxPJVGd0hlkzQVvPm0Xt0X1GdL68pVM/RiIldCBO8pjQFfeDNthNoQR6u9ApYc0z
         xqQhUbfn1r59heMHWHRJp9qhkDqXzTbb+KpPI=
Date: Sat, 7 Aug 2010 11:58:52 +0200
From: Dan Carpenter <error27@gmail.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
        Alan Cox <alan@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Rakib Mullick <rakib.mullick@gmail.com>,
        Ben Hutchings <ben@decadent.org.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/18] char: moxa: call disable_pci_device() if
	pci_probe() failed
Message-ID: <20100807095852.GX9031@bicker>
Mail-Followup-To: Dan Carpenter <error27@gmail.com>,
	Vasiliy Kulikov <segooon@gmail.com>,
	kernel-janitors@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Alan Cox <alan@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Rakib Mullick <rakib.mullick@gmail.com>,
	Ben Hutchings <ben@decadent.org.uk>, linux-kernel@vger.kernel.org
References: <1281124152-12630-1-git-send-email-segooon@gmail.com> <20100807072205.GW9031@bicker> <20100807085512.GA5783@albatros>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100807085512.GA5783@albatros>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1803
Lines: 45

On Sat, Aug 07, 2010 at 12:55:12PM +0400, Vasiliy Kulikov wrote:
> On Sat, Aug 07, 2010 at 09:22 +0200, Dan Carpenter wrote:
> > On Fri, Aug 06, 2010 at 11:49:10PM +0400, Kulikov Vasiliy wrote:
> > > Driver should call disable_pci_device() if it returns from pci_probe()
> > > with error. Also it must not be called if pci_request_region() fails as
> > > it means that somebody uses device resources and rules the device.
> > > 
> > 
> > I think we should disable it actually.  The comments on
> > pci_enable_device() and pci_disable_device() say that only the first and
> > last callers actually enable and disable it.  The others just increment
> > or decrement a counter.
> 
> See this thread: http://lkml.org/lkml/2005/2/13/82
> 
> Specifically this mail:
> 
>     Date    Mon, 14 Feb 2005 14:51:26 -0500
>     From    Jeff Garzik <>
> 
>     ...
>     You also need to consider situations such as out-of-tree drivers 
>     for the same hardware (might not use PCI API), and situations where you 
>     have peer devices discovered and used (PCI API doesn't have "hey, <this> 
>     device is associated with <current driver>, too" capability).
>     ...
> 
> Searching for 'pci_disable_device() inurl:lkml' doesn't give me newer info
> aboud this problem, so I think it's better to play safe.
> 

That's ancient.  That's a couple months before the start of git.

git show v2.6.12:drivers/pci/pci.c 

In those days pci_enable/disable_device() were not nestable.  These days
we can just unwind normally so it's a big improvement.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/