Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752976Ab0HIAUt (ORCPT ); Sun, 8 Aug 2010 20:20:49 -0400 Received: from gate.crashing.org ([63.228.1.57]:58658 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600Ab0HIAUs (ORCPT ); Sun, 8 Aug 2010 20:20:48 -0400 Subject: Re: [PATCH 1/1] integer overflow issue in 'appletouch' driver From: Benjamin Herrenschmidt To: Johannes Berg Cc: Serge Belyshev , Vadim Zaliva , Dmitry Torokhov , linux-kernel@vger.kernel.org In-Reply-To: <1281196050.4431.4.camel@jlt3.sipsolutions.net> References: <1268034117.3819.1.camel@jlt3.sipsolutions.net> <36779F26-DB1B-46ED-8635-01B03E559B55@crocodile.org> <20100310062227.GB2445@core.coreip.homeip.net> <87k4o234lx.fsf@depni.sinp.msu.ru> <1281196050.4431.4.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Date: Mon, 09 Aug 2010 10:20:23 +1000 Message-ID: <1281313223.2168.46.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 610 Lines: 21 > > My device is 05ac:020e "fountain", actually generates *signed* values, > > thus the patch completely breaks it. > > I think Ben might have the same issue. I guess we need per-touchpad > functions to read the data. Yup, I confirm, same deal. This patch completely breaks it on my powerbook (same USB ID) Should we revert the commit for now ? Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/